Skip to content

feat: add desktop environment and window manager categories with icons #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2024

Conversation

hasecilu
Copy link
Collaborator

@hasecilu hasecilu commented Apr 7, 2024

Bifurcation from #433

I tried to use "official" color of the logos but the darker ones were adjusted a bit. dwm uses the suckless color.

I'm not sure what causes the error in Xterm, I need to look for a patched font to test there and urxvt, Symbols only fallbacks on Alacritty.

Does this PR causes also problem?

Fix #432

@alex-courtis
Copy link
Member

I'm not sure what causes the error in Xterm, I need to look for a patched font to test there and urxvt, Symbols only fallbacks on Alacritty.

Does this PR causes also problem?

This branch is fine. It appears to be an issue with one of the additional icons not in this PR.

@alex-courtis
Copy link
Member

Returning OK:

print(require("nvim-web-devicons").get_icon("i3"))
print(require("nvim-web-devicons").get_icon("plasma"))

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the addition!

@alex-courtis alex-courtis changed the title feat: add DE & WM categories feat: add desktop environment and window manager categories and icons Apr 7, 2024
@alex-courtis alex-courtis changed the title feat: add desktop environment and window manager categories and icons feat: add desktop environment and window manager categories with icons Apr 7, 2024
@alex-courtis alex-courtis merged commit 20921d3 into nvim-tree:master Apr 7, 2024
@hasecilu hasecilu deleted the feat/add_DE_WM_categories branch April 8, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a category for icons from desktop environments and window managers
2 participants