Skip to content

refactor: expose context window #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phanen
Copy link
Contributor

@phanen phanen commented May 2, 2025

Problem

To attach treesitter-context on a float window, we need to create context with a larger zindex than the float window.

However there's no way to properly achieve it, since all context win use the same config.zindex.
(so larger config.zindex cause float window overlap with the context attached on non-float window)

image

Solution

Make render.open accept an win_config. (But I'm not sure if this will increase maintain burden here).

Another way is expose context_winid, so we can fix zindex later by nvim_win_set_config.

(A downstream fix ibhagwan/fzf-lua#2023 via this)

@phanen phanen marked this pull request as draft May 2, 2025 03:32
@phanen phanen marked this pull request as ready for review May 2, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant