chore: rework nix_flake_fmt to use the new nix formatter subcommand
#279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core `nix` accepted [my PR to add a new `nix formatter build` command](NixOS/nix#13063)! That means we can (eventually) get rid of this huge mess of code. I'm excited to try out the new feature, so I (unfortunately) made things even more complicated by adding a "new" and and "old" codepath. I've structured things so somebody with no knowledge of this code could remove the legacy codepath in the future.
jfly
force-pushed
the
simplify-nix_flake_fmt
branch
from
8ec6d56 to
d5494a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core
nixaccepted my PR to add a newnix formatter buildcommand!That means we can (eventually) get rid of this huge mess of code. I'm excited to try out the new feature, so I (unfortunately) made things even more complicated by adding a "new" and and "old" codepath. I've structured things so somebody with no knowledge of this code could remove the legacy codepath in the future.