Skip to content

TT-4464: fix parsing of events exception error#320

Merged
googsvg merged 3 commits intomainfrom
TT-4464-java-sdk-fix-parsing-of-events-can-throw-an-exception-if-conferencing-provider-name-doesnt-match-any-value-from-enum
May 6, 2026
Merged

TT-4464: fix parsing of events exception error#320
googsvg merged 3 commits intomainfrom
TT-4464-java-sdk-fix-parsing-of-events-can-throw-an-exception-if-conferencing-provider-name-doesnt-match-any-value-from-enum

Conversation

@googsvg
Copy link
Copy Markdown
Contributor

@googsvg googsvg commented May 6, 2026

Summary

  • Fix JsonDataException crash when Nylas API returns an unrecognized conferencing provider (e.g. "Hangouts"). Unrecognized values now deserialize to null instead of throwing.
  • Applied the same fix to CreateEventAutoConferencingProvider and CreateEventManualConferencingProvider for consistency.
  • Expose url, originalErrorMessage, and timeout as readable properties on NylasSdkRemoteClosedError / NylasSdkTimeoutError.
  • Fix deprecated RequestBody.create() calls; suppress legitimate Moshi adapter warnings (UNUSED_PARAMETER, UNCHECKED_CAST).

Closes #265

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@googsvg googsvg requested a review from AaronDDM May 6, 2026 13:54
@googsvg googsvg changed the title Tt 4464 java sdk fix parsing of events can throw an exception if conferencing provider name doesnt match any value from enum TT-4464: fix parsing of events exception error May 6, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.49%. Comparing base (fd75345) to head (d953a36).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #320      +/-   ##
============================================
+ Coverage     82.44%   82.49%   +0.05%     
  Complexity      358      358              
============================================
  Files            38       38              
  Lines          1031     1034       +3     
  Branches         95       95              
============================================
+ Hits            850      853       +3     
  Misses          122      122              
  Partials         59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@googsvg googsvg merged commit 8b69f75 into main May 6, 2026
5 checks passed
@googsvg googsvg deleted the TT-4464-java-sdk-fix-parsing-of-events-can-throw-an-exception-if-conferencing-provider-name-doesnt-match-any-value-from-enum branch May 7, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parsing of events can throw an exception if ConferencingProvider name doesn't match any value from enum

3 participants