Fix IAU rotations of Neptune and Uranus do not match SPICE #490
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ephraim71, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a critical bug where the NAIF IDs for Uranus and Neptune were incorrectly assigned within the system, leading to discrepancies in IAU rotation data when compared to external SPICE data. The core change involves swapping these constant values, which in turn allowed previously failing or disabled validation tests for these planets to be re-enabled and pass, ensuring the accuracy of planetary orientation calculations.
Highlights
- Bug Fix: NAIF ID Correction: Corrected the interchanged NAIF (Navigation and Ancillary Information Facility) IDs for Uranus and Neptune in the
anise/src/constants.rsfile. Previously,IAU_NEPTUNEwas assigned799andIAU_URANUSwas899, which has now been swapped toIAU_URANUS = 799andIAU_NEPTUNE = 899to match SPICE data. - Test Enablement: Uncommented and re-enabled the
IAU_URANUS_FRAMEandIAU_NEPTUNE_FRAMEvalidation tests inanise/tests/orientations/validation.rs. This indicates that the previous bug preventing these tests from passing has been resolved, and the IAU rotation calculations for these planets now align with expected values.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
No way! That's it?! THANKS! I've been so confused by this bug for a while! |
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug where the NAIF IDs for the IAU frames of Uranus and Neptune were swapped. The change is simple and effective, and the corresponding tests have been re-enabled to validate the fix. I've added one suggestion to improve code maintainability by linking the orientation constants to their corresponding celestial body constants, which would make the code more robust against similar issues in the future.
|
I am super glad you found and fixed this, thank you! |
Summary
Fixes #185
NAIF ID of Uranus and Neptune were interchanged. This caused mismatch with SPICE.
https://naif.jpl.nasa.gov/pub/naif/toolkit_docs/C/req/naif_ids.html
Architectural Changes
No change
New Features
No change
Improvements
No change
Bug Fixes
#185
Testing and validation
Uncommented the
validate_iau_rotation_to_planettest for Uranus and NeptuneDocumentation
This PR does not primarily deal with documentation changes.