Skip to content

Move salsa-simple from tools/ to vendor/ and alphabetize workspace #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 31, 2025
Merged

Move salsa-simple from tools/ to vendor/ and alphabetize workspace #1580

merged 4 commits into from
Oct 31, 2025

Conversation

@dannywillems
Copy link
Member

@dannywillems dannywillems commented Oct 30, 2025

salsa-simple is not a tool but a vendored reimplementation of XSalsa20 with serde support, which the external salsa20 crate lacks. Moving it to vendor/ better reflects its purpose as a vendored dependency.

Also alphabetized workspace members in Cargo.toml for better organization and removed duplicate ledger entry.

@github-actions
Copy link

github-actions bot commented Oct 30, 2025 •
edited
Loading

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ✓ Validation passed

Click to see full validation output 
Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d

Validating references...
========================
✓ VALID: ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
  ⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2407
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e8e5f9e0dd346abb4f993d614c73da0b87f91b3d)

Summary
=======
Total references found: 16
Valid references: 16
Invalid references: 0
Stale commits: 16

⚠ Warning: 16 reference(s) have stale commits
Run with --update to update them automatically

@dannywillems dannywillems force-pushed the dw/remove-salsa-simple branch from fc82752 to c3631d2 Compare October 30, 2025 18:55
@github-actions
Copy link

github-actions bot commented Oct 30, 2025 •
edited
Loading

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

richardpringle
richardpringle approved these changes Oct 31, 2025
View reviewed changes
Cargo.toml
"tools/transport",
"producer-dashboard",
"snark",
"tools/archive-breadcrumb-compare",
Copy link
Contributor

@richardpringle richardpringle Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, taplo has a setting to do this, I'm pretty sure

@dannywillems dannywillems force-pushed the dw/remove-salsa-simple branch 5 times, most recently from e07397f to a7b7943 Compare October 31, 2025 13:52
@dannywillems
Move salsa-simple from tools/ to vendor/ and alphabetize workspace
bb17719 
salsa-simple is not a tool but a vendored reimplementation of XSalsa20
with serde support, which the external salsa20 crate lacks. Moving it
to vendor/ better reflects its purpose as a vendored dependency.

Also alphabetized workspace members in Cargo.toml for better
organization and removed duplicate ledger entry.
@dannywillems
CHANGELOG: add entry for patch 1580
d32ece0
@dannywillems
Document why salsa-simple is vendored in lib.rs
b2bdee9 
Add comprehensive module-level documentation explaining that this is a
vendored XSalsa20 implementation created because the external salsa20
crate lacks serde support needed for Redux state serialization.
@dannywillems
Frontend/angular: update configuration for production
5776835
@dannywillems dannywillems force-pushed the dw/remove-salsa-simple branch from a7b7943 to 5776835 Compare October 31, 2025 13:53
@dannywillems
Copy link
Member Author

dannywillems commented Oct 31, 2025

I'm force-merging as it will fail only for the wallet and scenario-tests.

@dannywillems dannywillems merged commit 9d6c59b into develop Oct 31, 2025
70 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardpringle richardpringle richardpringle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Rust node
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dannywillems @richardpringle