fix: use correct wasm classes for Gate and PolyComm construction #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Galoretka wants to merge 1 commit into o1-labs:main from Galoretka:fix/conversion-core-wasm-class-usage

Galoretka commented Jul 13, 2025 •

edited

Loading

Refactored conversion-core.ts to avoid type/value conflicts for Gate and PolyComm.

Import Gate and PolyComm only as types from kimchi-types.ts.
Use the wasm class constructors from WasmClasses for creating wasm objects.
Renamed function arguments to prevent naming conflicts.

This ensures correct instantiation of wasm objects and prevents runtime errors related to type misuse.


          fix: use correct wasm classes for Gate and PolyComm construction

7676a66

Galoretka requested a review from a team as a code owner

July 13, 2025 12:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet