Add datasource ovirt_vnic_profile.
#509
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Zandbergen <justin.zandbergen@topicus.nl>
Signed-off-by: Justin Zandbergen <justin.zandbergen@topicus.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the change you are making
Add the datasource
ovirt_vnic_profile.This because when using the resource
ovirt_nicone needs to supply thevnic_profile_idattribute but it is nowhere exposed in the oVirt UI (4.5). This PR would make it easy to lookup this id by using a datasource.Are you the owner of the code you are sending in, or do you have permission of the owner?
yes
The code will be published under the BSD 3 clause license. Have you read and understood this license?
yes
Notes
internal/ovirt/data_source_ovirt_vnic_profile_test.go:17and would need some help with that.Thank you very much for your time.