Fix flashing wrong layout on init #2188
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lukaw3d
force-pushed
the
lw/flashing-wrong-layout
branch
from
a89f18e to
d2609d8
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
playwright test broke because useRouteRedirects now redirects away from e2e before setIsResponsiveContextInitialized(true) lets it to be rendered. Ignoring this until #823 |
|
What's an issue with a failing test? It's fine when I run it locally using this side branch. edit: oh I did not see your comment. So the plan is to merge this with a test that will always fail on CI? |
|
I would just ignore this PR and layout issue until #823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1863