libobs-opengl: Reject external-only modifiers #12507
Open
+20
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These modifiers cannot be used with the standard texture sampling codepaths, so we need to reject them to avoid invalid GL operations.
Closes #12498
Motivation and Context
See #12498, this should force cross-GPU PipeWire capture to fall back to shm if the Nvidia proprietary driver is in use, since it apparently cannot support any DMA-BUF import formats at all using standard mechanisms.
How Has This Been Tested?
Smoke tested on an Apple system. Needs testing by the affected user.
Types of changes
Checklist: