fix(root_module): missing dependencies in the sandbox#13842
Open
anmonteiro wants to merge 1 commit intoocaml:mainfrom
Open
fix(root_module): missing dependencies in the sandbox#13842anmonteiro wants to merge 1 commit intoocaml:mainfrom
anmonteiro wants to merge 1 commit intoocaml:mainfrom
Conversation
rgrinberg
reviewed
Mar 19, 2026
src/dune_rules/module_compilation.ml
Outdated
| | Impl, true -> | ||
| let dep_graph = Ml_kind.Dict.get (Compilation_context.dep_graphs cctx) Intf in | ||
| let module_deps = Dep_graph.deps_of dep_graph m in | ||
| other_intf_cm_files ~obj_dir ~cm_kind ~module_deps |
Member
There was a problem hiding this comment.
Why do we need to do this work here? Why don't we add these modules when constructing the dep graph?
But setting that aside, I'm not sure why this helps because I thought we already took all transitive deps of the cmi's.
anmonteiro
force-pushed
the
anmonteiro/fix-missing-deps-root-module
branch
7 times, most recently
from
f9f2699 to
8685b78
Compare
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/fix-missing-deps-root-module
branch
from
8685b78 to
f34d57b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.