Merge pull request #70 from JaimeCalzadaNOAA/develop

handle URL given to HAMTIDE, datetime given to `.start_date`

Author: zacharyburnett

adcircpy/forcing/tides/hamtide.py

@@ -19,12 +19,15 @@ class HAMTIDE(TidalDataset):
     def __init__(self, hamtide_dataset_directory: PathLike = None):
         if hamtide_dataset_directory is None:
             hamtide_dataset_directory = self.OPENDAP_URL
-
-        if Path(hamtide_dataset_directory).exists():
-            hamtide_dataset_directory = Path(hamtide_dataset_directory)
-            if len(list(hamtide_dataset_directory.glob('*.nc'))) == 0:
-                raise FileNotFoundError(f'no NetCDF files found at '
-                                        f'"{hamtide_dataset_directory}"')
+        else:
+            try:
+                if Path(hamtide_dataset_directory).exists():
+                    hamtide_dataset_directory = Path(hamtide_dataset_directory)
+                    if len(list(hamtide_dataset_directory.glob('*.nc'))) == 0:
+                        raise FileNotFoundError(f'no NetCDF files found at '
+                                                f'"{hamtide_dataset_directory}"')
+            except OSError:
+                raise ValueError('given resource must be a local path')
 
         super().__init__(hamtide_dataset_directory)
 

adcircpy/fort15.py

@@ -2271,6 +2271,8 @@ def _get_TOUTS__(self, output_type, physical_var):
                 start = start - self.forcing_start_date
             else:
                 start = start - self.start_date
+        elif isinstance(start, datetime):
+            start = self.start_date - start
 
         elif isinstance(start, type(None)):
             if self._runtype == 'hotstart':
@@ -2279,7 +2281,7 @@ def _get_TOUTS__(self, output_type, physical_var):
             else:
                 return 0
 
-        return start.total_seconds() / (60.0 * 60.0 * 24.0)
+        return start / timedelta(days=1)
 
     def _get_TOUTF__(self, output_type, physical_var):
         output = self._container[output_type][physical_var]
@@ -2298,7 +2300,7 @@ def _get_TOUTF__(self, output_type, physical_var):
                     else:
                         return 0
                 else:
-                    raise NotImplementedError
+                    raise NotImplementedError('specific spinup end time is not implemented')
             else:
                 return 0