Skip to content

Fix DeprecationWarning #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

Fix DeprecationWarning #54

merged 2 commits into from
May 30, 2025

Conversation

lucduron
Copy link
Collaborator

Warnings which are fixed:

xarray_selafin\xarray_backend.py:165: DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implement 'dtype' and 'copy' keyword arguments.
  temp[iv] = ds[var]

xarray_selafin\xarray_backend.py:167: DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implement 'dtype' and 'copy' keyword arguments.
  temp[iv] = ds.isel(time=it)[var]

lucduron added 2 commits May 28, 2025 16:45
@lucduron
Fix DeprecationWarning
0181b22 
xarray_selafin\xarray_backend.py:166: DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implement 'dtype' and 'copy' keyword arguments.
    temp[iv] = ds.isel(time=it)[var]
@lucduron
FIx tests (use actions/cache@v3)
ac5fc09
@lucduron
Copy link
Collaborator Author

The third and last PR of the day ;)
Thank you for the integration !

@tomsail tomsail merged commit 9133af9 into oceanmodeling:main May 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsail tomsail tomsail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucduron @tomsail