Explained canvas-level extensions better #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the documentation for canvas-level extensions in the OCIF v0.6.1 specification. It adds clarifying text and an example to better explain how extensions can be applied at the canvas level, similar to how they work for nodes and relations.
- Added detailed explanation of canvas-level extensions with an example
- Fixed table formatting inconsistencies in markdown tables
- Added changelog entry for the v0.6.1 update
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/v0.6.1-draft/spec.md | Added comprehensive documentation for canvas-level extensions including example, fixed markdown table formatting, and updated changelog |
| spec/v0.6.1-draft/schema.json | Added data property definition for canvas-level extensions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ```json | ||
| { | ||
| "ocif": "https://spec.canvasprotocol.org/v0.6.1/schema.json", |
There was a problem hiding this comment.
The ocif property value should use https://canvasprotocol.org/ocif/v0.6.1 to be consistent with other examples in the document (lines 171, 297, 307) rather than the schema URL https://spec.canvasprotocol.org/v0.6.1/schema.json.
Suggested change
| "ocif": "https://spec.canvasprotocol.org/v0.6.1/schema.json", | |
| "ocif": "https://canvasprotocol.org/ocif/v0.6.1", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request explains canvas-level extensions to the OCIF specification, allowing applications to attach extension objects directly to the canvas. The main changes clarify how these extensions are represented, update the schema, and improve documentation for developers.