fix broken agp9 compat#485
Merged
DennisAlund merged 2 commits intooddbit:mainfrom Apr 28, 2026
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
Author
Per AGP 9's migrate-to-built-in-kotlin guide, `kotlin.compilerOptions.jvmTarget`
defaults to `android.compileOptions.targetCompatibility`, which is already set
to JVM_17 above. Setting it explicitly is redundant. The official DSL is also
top-level, not nested inside `android { }` — sidestep the placement question by
removing the block entirely.
This also drops the `org.jetbrains.kotlin.gradle.dsl.JvmTarget` reference, so
the legacy `kotlinOptions { jvmTarget = "17" }` is the only Kotlin compile
configuration left, gated to the `!useBuiltInKotlin` branch where it's valid.
Refs: https://developer.android.com/build/migrate-to-built-in-kotlin
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
@claude review |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Android Gradle configuration to restore compatibility with AGP 9’s built-in Kotlin support, while still supporting the opt-out path (android.builtInKotlin=false) where the Kotlin Android plugin must be applied explicitly.
Changes:
- Detects AGP 9 +
android.builtInKotlinto decide whether to applykotlin-android. - Skips the
kotlinOptionsDSL when built-in Kotlin is enabled (since it’s not available withoutkotlin-android).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thank you for the contributions. Merged and released: https://pub.dev/packages/facebook_app_events/versions/0.27.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.