Remove heap coverage code in favor of external tooling

Author: Feoramund

.github/workflows/ci.yml

@@ -34,7 +34,7 @@ jobs:
           ./odin check examples/all -vet -strict-style -disallow-do -target:netbsd_arm64
           ./odin check vendor/sdl3  -vet -strict-style -disallow-do -target:netbsd_amd64 -no-entry-point
           ./odin check vendor/sdl3  -vet -strict-style -disallow-do -target:netbsd_arm64 -no-entry-point
-          ./odin run tests/heap_allocator -vet -strict-style -disallow-do -define:ODIN_DEBUG_HEAP=true -- -allocator=feoramalloc -vmem-tests -serial-tests -parallel-tests
+          ./odin run tests/heap_allocator -vet -strict-style -disallow-do -debug -- -allocator=feoramalloc -vmem-tests -serial-tests -parallel-tests
           ./odin test tests/core/normal.odin -file -all-packages -vet -strict-style -disallow-do -define:ODIN_TEST_FANCY=false -define:ODIN_TEST_FAIL_ON_BAD_MEMORY=true
           ./odin test tests/core/speed.odin -file -all-packages -vet -strict-style -disallow-do -o:speed -define:ODIN_TEST_FANCY=false -define:ODIN_TEST_FAIL_ON_BAD_MEMORY=true
           ./odin test tests/vendor -all-packages -vet -strict-style -disallow-do -define:ODIN_TEST_FANCY=false -define:ODIN_TEST_FAIL_ON_BAD_MEMORY=true
@@ -66,7 +66,7 @@ jobs:
           gmake -C vendor/miniaudio/src
           ./odin check examples/all -vet -strict-style -disallow-do -target:freebsd_amd64
           ./odin check vendor/sdl3  -vet -strict-style -disallow-do -target:freebsd_amd64 -no-entry-point
-          ./odin run tests/heap_allocator -vet -strict-style -disallow-do -define:ODIN_DEBUG_HEAP=true -- -allocator=feoramalloc -vmem-tests -serial-tests -parallel-tests
+          ./odin run tests/heap_allocator -vet -strict-style -disallow-do -debug -- -allocator=feoramalloc -vmem-tests -serial-tests -parallel-tests
           ./odin test tests/core/normal.odin -file -all-packages -vet -strict-style -disallow-do -define:ODIN_TEST_FANCY=false -define:ODIN_TEST_FAIL_ON_BAD_MEMORY=true
           ./odin test tests/core/speed.odin -file -all-packages -vet -strict-style -disallow-do -o:speed -define:ODIN_TEST_FANCY=false -define:ODIN_TEST_FAIL_ON_BAD_MEMORY=true
           ./odin test tests/vendor -all-packages -vet -strict-style -disallow-do -define:ODIN_TEST_FANCY=false -define:ODIN_TEST_FAIL_ON_BAD_MEMORY=true
@@ -126,7 +126,7 @@ jobs:
       - name: Odin check vendor/sdl3
         run: ./odin check vendor/sdl3  -strict-style -vet -disallow-do -no-entry-point
       - name: Odin heap allocator tests
-        run: ./odin run tests/heap_allocator -vet -strict-style -disallow-do -define:ODIN_DEBUG_HEAP=true -sanitize:thread -- -allocator=feoramalloc -vmem-tests -serial-tests -parallel-tests
+        run: ./odin run tests/heap_allocator -vet -strict-style -disallow-do -debug -sanitize:thread -- -allocator=feoramalloc -vmem-tests -serial-tests -parallel-tests
       - name: Normal Core library tests
         run: ./odin test tests/core/normal.odin -file -all-packages -vet -strict-style -disallow-do -define:ODIN_TEST_FANCY=false -define:ODIN_TEST_FAIL_ON_BAD_MEMORY=true
       - name: Optimized Core library tests
@@ -219,7 +219,7 @@ jobs:
         shell: cmd
         run: |
           call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat
-          odin run tests/heap_allocator -vet -strict-style -disallow-do -define:ODIN_DEBUG_HEAP=true -- -allocator=feoramalloc -vmem-tests -serial-tests -parallel-tests
+          odin run tests/heap_allocator -vet -strict-style -disallow-do -debug -- -allocator=feoramalloc -vmem-tests -serial-tests -parallel-tests
       - name: Core library tests
         shell: cmd
         run: |
@@ -315,7 +315,7 @@ jobs:
         run: ./odin run examples/demo -debug -vet -strict-style -disallow-do -target:linux_riscv64 -extra-linker-flags:"-fuse-ld=/usr/bin/riscv64-linux-gnu-gcc-12 -static -Wl,-static" -no-rpath
 
       - name: Odin heap allocator tests
-        run: ./odin run tests/heap_allocator -vet -strict-style -disallow-do -target:linux_riscv64 -extra-linker-flags:"-fuse-ld=/usr/bin/riscv64-linux-gnu-gcc-12 -static -Wl,-static" -no-rpath -define:ODIN_DEBUG_HEAP=true -- -allocator=feoramalloc -vmem-tests -serial-tests -parallel-tests
+        run: ./odin run tests/heap_allocator -vet -strict-style -disallow-do -target:linux_riscv64 -extra-linker-flags:"-fuse-ld=/usr/bin/riscv64-linux-gnu-gcc-12 -static -Wl,-static" -no-rpath -debug -- -allocator=feoramalloc -vmem-tests -serial-tests -parallel-tests
 
       - name: Normal Core library tests
         run: ./odin test tests/core/normal.odin -file -all-packages -vet -strict-style -disallow-do -define:ODIN_TEST_FANCY=false -define:ODIN_TEST_FAIL_ON_BAD_MEMORY=true -target:linux_riscv64 -extra-linker-flags:"-fuse-ld=/usr/bin/riscv64-linux-gnu-gcc-12 -static -Wl,-static" -no-rpath

base/runtime/heap_allocator_debugging.odin

@@ -17,8 +17,6 @@ import "core:mem"
 
 import libc_allocator "libc"
 
-ODIN_DEBUG_HEAP :: runtime.ODIN_DEBUG_HEAP
-
 // The tests are specific to feoramalloc, but the benchmarks are general-purpose.
 
 //
@@ -851,7 +849,6 @@ main :: proc() {
 		compact:             bool `usage:"Compact the heap at the end."`,
 		info:                bool `usage:"Show heap info at the end."`,
 		trap:                bool `usage:"Trigger a debug trap at the end."`,
-		coverage:            bool `usage:"Check code coverage."`,
 	}
 
 	opt: Options
@@ -970,9 +967,6 @@ main :: proc() {
 				expect(err2 == nil)
 				_, err3 := allocator.procedure(allocator.data, .Free, 0, 0, raw_data(o2), 0)
 				expect(err3 == nil)
-				when ODIN_DEBUG_HEAP {
-					expect(intrinsics.atomic_load(&runtime.heap_global_code_coverage[.Resize_Wide_Slab_Expanded_In_Place]) == 1)
-				}
 			}
 
 			// Inter-bin tests.
@@ -1173,20 +1167,6 @@ main :: proc() {
 		log.info("The main thread's heap has been compacted.")
 	}
 
-	if opt.coverage {
-		when runtime.ODIN_DEBUG_HEAP {
-			log.info("--- Code coverage report ---")
-			for key in runtime.Heap_Code_Coverage_Type {
-				value := intrinsics.atomic_load_explicit(&runtime.heap_global_code_coverage[key], .Acquire)
-				log.infof("%s%v: %v", ">>> " if value == 0 else "", key, value)
-			}
-
-			log.infof("Full code coverage: %v", runtime._check_heap_code_coverage())
-		} else {
-			log.error("ODIN_DEBUG_HEAP is not enabled, thus coverage cannot be calculated.")
-		}
-	}
-
 	// for ptr, entry in tracker.allocation_map {
 	// 	log.infof("%p -- %v", ptr, entry)
 	// }