Skip to content

WIP real-valued functional #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

WIP real-valued functional #1333

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d4e5498
Tried to make functional possible to map to real numbers istead of sp…
Apr 26, 2018
7a278f0
Merge branch 'master' of https://github.com/miallo/odl
Apr 26, 2018
09b1e94
Continued implementation of functionals mapping to RealNumbers
Apr 26, 2018
89652b1
Added range to functional operations
Apr 27, 2018
69521ba
Continued to implement range in default_functionals
Apr 27, 2018
85650f7
Mostly continued default_fuctionals
Apr 27, 2018
7382635
fixed mistake where renaming proximal_l* function inputs to `domain`
Apr 27, 2018
246a31b
fixed range of QuadraticForm-Functional
Apr 27, 2018
5a55e75
Implemented most comments from @kohr-h and @aringh
Apr 27, 2018
d1c4d68
Is there a reason for ufunc_ops to pass the explicit keyword `domain=…
Apr 27, 2018
9003572
Added docstrings for `range` parameter
Apr 27, 2018
77842df
Fields can now be added to the "highest" one
Apr 29, 2018
c7a6127
Removed addition of fields again, Reverted `__repr__` not to include …
Apr 29, 2018
3fa93d9
Changed the order to (domain, range, ...) in __init__ calls and fixed
May 31, 2018
0951041
fixed typo in forward-backward documentation
Jun 5, 2018
0ddd06c
Merged from odl main branch
Jun 13, 2018
cb6df08
CallbackShowConvergence now supports saveto
Jun 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion odl/ufunc_ops/ufunc_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ def __init__(self, field):
"".format(name))

linear = name in LINEAR_UFUNCS
Functional.__init__(self, space=field, linear=linear)
Functional.__init__(self, domain=field, linear=linear)
Copy link
Contributor Author

@miallo miallo Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there an explicit keyword passed in here for space/domain?
I have absolutely no experience with unit testing, so someone else needs to write the tests...

Copy link
Member

@kohr-h kohr-h Apr 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just for clarity.

If you write Functional.__init__(domain, range, linear) it's obvious what each of the arguments does, and keywords just add noise: Functional.__init__(domain=domain, range=range, linear=linear).
On the other hand, something like Functional.__init__(field, True) doesn't convey any information about the purpose of the arguments, so here Functional.__init__(domain=field, linear=True) is much clearer.

But why is this related to tests?

Copy link
Contributor Author

@miallo miallo Apr 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stumbled across it in the test results and wanted to make sure that someone else takes over when I am done with implementing most of the stuff


def _call(self, x):
"""Return ``self(x)``."""
Expand Down