-
Notifications
You must be signed in to change notification settings - Fork 359
shizuku added to tools #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1034,6 +1035,7 @@ A list of **Free** and **Open Source Software** ***(FOSS)*** for **Android** – | |||
* [**APKLab**](https://github.com/APKLab/APKLab) | |||
* [**Apktool**](https://github.com/iBotPeaches/Apktool) | |||
* [**APKToolGUI**](https://github.com/AndnixSH/APKToolGUI) | |||
* [**Shizuku**](https://github.com/RikkaApps/Shizuku) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -276,6 +276,7 @@ A list of **Free** and **Open Source Software** ***(FOSS)*** for **Android** – | |||
* [**MJ PDF Reader**](https://gitlab.com/mudlej_android/mj_pdf_reader) | |||
* [**MuPDF**](http://mupdf.com/) <sup>**[[F-Droid](https://f-droid.org/app/com.artifex.mupdf.viewer.app)]**</sup> | |||
* [**Orion Viewer**](https://github.com/max-kammerer/orion-viewer) <sup>**[[F-Droid](https://f-droid.org/app/universe.constellation.orion.viewer)]**</sup> | |||
* [**Pdf Viewer**](https://github.com/Swati4star/Images-to-PDF) <sup>**[[F-Droid](https://f-droid.org/app/swati4star.createpdf)]**</sup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #532 comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why " PDF viewer" commit is coming along with the shizuku commit , i intention is only to give to shizuku as pr , I am new to this can you tell me what's wrong , I know pdf viewer is already merged to the main branch. Should I delete my fork and refork ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this PR the simplest solution is to remove that line, create a commit and push it to your branch. This is going to update the PR too. No need to refork :-).
General recommendation is to keep the master branch of your fork in sync with this repository and create PRs from branches.
Also check if your local git branches are up to date with their remote counterpart on Github.
Let me know if you need further help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you , I'll try and update
No description provided.