Skip to content

Conversation

mdrdannyr
Copy link

When reading from OKTA API, SAML Applications that have preconfigured attribution statements are stored within 'configuredAttributeStatements'.

This is currently not passed to the results var when using get_application

This fix updates the model so that the value is passed

When reading from OKTA API, SAML Applications that have preconfigured attribution statements are stored within 'configuredAttributeStatements'. 

This is currently not passed to the results var when using get_application 

This fix updates the model so that the value is passed
@mdrdannyr
Copy link
Author

To provide more context and details:

This is what direct API call to OKTA using postman shows:

image

This is what the library returns from the get_application call:

image

As can be seen the configuredAttributeStatements are missing.

OKTA docs show the following regarding this key:

image

Uncertain if the code is correct and stands up to your own guidelines. Happy to work with someone to get this merged in

@mdrdannyr
Copy link
Author

closes #374

@mdrdannyr
Copy link
Author

Hi

@bryanapellanes-okta
@bretterer

Hope you're both doing well.

Tagging you as i see you guys are quite active in the latest commits to master. Could either of you help me out here in getting this relatively small fix into a release?

@bryanapellanes-okta
Copy link
Contributor

@mdrdannyr I apologize for the delayed response and thank you for your submission. To ensure integrity, please provide a unit test that fails prior to your proposed change and passes with your change in place.

We appreciate your engagement and thanks for using Okta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants