fix: Ensure we drop user after tool messages

Author: flovilmart

lua/codecompanion/adapters/http/mistral.lua

@@ -61,6 +61,20 @@ return {
       return openai.handlers.form_parameters(self, params, messages)
     end,
     form_messages = function(self, messages)
+      local is_previous_tool = false
+      local messages = vim.iter(messages):filter(function(msg)
+        local is_tool = msg.role == "tool"
+        local is_user = msg.role == "user"
+        local keep = true
+        -- Mistral does not like user after tool messages, those should always be assistant
+        -- Worst case we drop 1 user message, but the assistant will respond to the tool
+        if is_previous_tool and is_user then
+          log:debug("Dropping user after tool message: %s", msg.content)
+          keep = false
+        end
+        is_previous_tool = is_tool
+        return keep
+      end)
       return openai.handlers.form_messages(self, messages)
     end,
     chat_output = function(self, data, tools)

tests/adapters/http/test_mistral.lua

@@ -50,6 +50,8 @@ T["Mistral adapter"]["form_messages"]["it can form messages with tools"] = funct
         },
       },
     },
+    { role = "tool", content = "ok" },
+    { role = "assistant", content = "that works" },
   }
 
   local expected = {
@@ -83,6 +85,56 @@ T["Mistral adapter"]["form_messages"]["it can form messages with tools"] = funct
           },
         },
       },
+      { role = "tool", content = "ok" },
+      { role = "assistant", content = "that works" },
+    },
+  }
+
+  h.eq(expected, adapter.handlers.form_messages(adapter, input))
+end
+
+T["Mistral adapter"]["form_messages"]["it skips messages when user follows tools"] = function()
+  local input = {
+    { role = "user", content = "User1" },
+    {
+      role = "llm",
+      tools = {
+        calls = {
+          {
+            ["function"] = {
+              arguments = '{"location":"London, UK","units":"fahrenheit"}',
+              name = "weather",
+            },
+            id = "call_1_a460d461-60a7-468c-a699-ef9e2dced125",
+            type = "function",
+          },
+        },
+      },
+    },
+    { role = "tool", content = "ok" },
+    { role = "user", content = "my message" },
+  }
+
+  local expected = {
+    messages = {
+      {
+        content = "User1",
+        role = "user",
+      },
+      {
+        role = "llm",
+        tool_calls = {
+          {
+            ["function"] = {
+              arguments = '{"location":"London, UK","units":"fahrenheit"}',
+              name = "weather",
+            },
+            id = "call_1_a460d461-60a7-468c-a699-ef9e2dced125",
+            type = "function",
+          },
+        },
+      },
+      { role = "tool", content = "ok" },
     },
   }