-
-
Notifications
You must be signed in to change notification settings - Fork 330
Add Gemini reasoning support #2306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
63db296 to
df03135
Compare
| "none", | ||
| }, | ||
| default = -1, -- dynamic reasoning | ||
| -- TODO: validate requires having `self` in the params. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since different models have different thinking budget, we might need to change validate so that it also accepts self in the parameters (something like validate(self, n) instead of the current validate(n). @olimorris would that be alright?
bb85994 to
0708fcf
Compare
|
Btw, this may also be the culprit behind the Gemini adapter having occasional time out error: it defaults to use dynamic thinking, but the cc adapter didn't request for the reasoning summary and thought it timed out. Maybe we should increase the default timeout for Gemini adapter or make it configurable? |
9346527 to
d51be6e
Compare
d51be6e to
4acfc8a
Compare
|
The |
be08265 to
8acd7f9
Compare
|
A few things after the gemini-3-pro release:
|
Description
Reference: https://ai.google.dev/gemini-api/docs/openai#thinking
Screenshots
Checklist
make allto ensure docs are generated, tests pass and my formatting is appliedCodeCompanion.hasin the init.lua file for my new feature