Skip to content

Commit e13229f

Browse files
authored
Buffer+tensor use full type name for signature (shader-slang#207)
* Buffer+tensor use full type name for signature * Try fixing pyright issue with declrefs
1 parent bb4464e commit e13229f

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

src/sgl/device/tests/test_declrefs.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -805,10 +805,7 @@ def test_ast_cursor_hashgrid_nogenerics(device_type: sgl.DeviceType):
805805

806806
# print_ast(module.module_decl, device)
807807
dump = ast_to_dict(module.module_decl, device)
808-
diff = DeepDiff(
809-
dump,
810-
HASHGRID_NO_GENERICS_DUMP,
811-
)
808+
diff = DeepDiff(dump, HASHGRID_NO_GENERICS_DUMP) # type: ignore (deepdiff issue)
812809
assert not diff
813810

814811

src/sgl/utils/python/slangpybuffer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ NativeNDBuffer::NativeNDBuffer(Device* device, NativeNDBufferDesc desc)
3232
m_storage = device->create_buffer(buffer_desc);
3333

3434
set_slangpy_signature(
35-
fmt::format("[{},{},{}]", desc.dtype->get_type_reflection()->name(), desc.shape.size(), desc.usage)
35+
fmt::format("[{},{},{}]", desc.dtype->get_type_reflection()->full_name(), desc.shape.size(), desc.usage)
3636
);
3737
}
3838

src/sgl/utils/python/slangpytensor.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ NativeTensor::NativeTensor(
6868
, m_grad_in(grad_in)
6969
, m_grad_out(grad_out)
7070
{
71-
set_slangpy_signature(fmt::format("[{},{},{}]", desc.dtype->get_type_reflection()->name(), dims(), usage()));
71+
set_slangpy_signature(fmt::format("[{},{},{}]", desc.dtype->get_type_reflection()->full_name(), dims(), usage()));
7272
}
7373

7474
ref<NativeTensor> NativeTensor::broadcast_to(const Shape& new_shape) const

0 commit comments

Comments
 (0)