Added support for Energy saving mode (airState.powerSave.basic) #739
Conversation
doesn't change it
…s, doesn't change it
|
I have 0.39.2 version installed and my AC is model "RAC_056905_WW-RAC (AC)" and I can't see the power save option.
|
|
Hi, this pull request has not yet been accepted, so the changes are not present. I have a fork of this repo with the energy saving change, but in the mean time I added some other things that are useful only for me so I can't recommend using it. |
|
Would be awesome that this feature will be integrated! I uploaded the files manually and its working like a charm! |
|
@ollo69 Is it possible to have this added to ha-smartthinq-sensors? |
| # if self._is_mode_supported(SUPPORT_LIGHT_INV_SWITCH): | ||
| # return {MODE_OFF: LIGHT_DISPLAY_INV_OFF, MODE_ON: LIGHT_DISPLAY_INV_ON} |
There was a problem hiding this comment.
Hi,
For me, RAC_88_DISPLAY_CONTROL displayed correctly the light on switch (not inverted as I saw others users reported). Because of the "inverted" code part, in my app the values were inverted. With that code commented, it displays fine for me.
Anyway, the commit d757db5 was not part of the original pull request, after around 2 weeks I thought the pull request is not accepted so I used this fork to add some changes for my personal needs and use it on my HA.
The original pull request was only for commit https://github.com/ollo69/ha-smartthinq-sensors/pull/739/commits/4ee1db93944a204fd13fcfad13d54ca3053cf6fc1.
Thanks and regards,
Andrei
There was a problem hiding this comment.
For me, RAC_88_DISPLAY_CONTROL displayed correctly the light on switch (not inverted as I saw others users reported). Because of the "inverted" code part, in my app the values were inverted. With that code commented, it displays fine for me.
This is the real problem in integration development, found the correct way to make it work properly for all possible devices. We should find a way to make this option work correctly for your device without breaking others.
after around 2 weeks I thought the pull request is not accepted so I used this fork to add some changes for my personal needs and use it on my HA.
The only problem is that this year my time to work on this integration is very limited, but there are no reason to reject a PR without at least a feedback. If there are no answer just means that I had no time to analyze it, but PR are always welcome.
Please attach your device diagnostics so that I will also take a look to the display settings available to try to found a possible solution.
There was a problem hiding this comment.
Hi,
Thanks for your reply. I have attached the device diagnostics, and looking into it I realised I remembered incorrectly the light problem. The "@RAC_88_DISPLAY_CONTROL" is not supported at all and "@BRIGHTNESS_CONTROL" that is used in integration's code as inverted value, for me it doesn't need to be inverted.
If you prefer, I could make a new pull request with only the Energy saving mode switch stuff, but not sure when, as I don't have a lot of time until the end of the month.
Thanks and regards,
Andrei
There was a problem hiding this comment.
I'm trying to figure out how to manage the light option more efficiently, as it seems that each device works differently (when it works at all)
|
Sorry for not working on this, unfortunately I'm very busy with job on this period, I hope I will find some time by the end of September. |
No problem, I also have zero free time for side projects (beside my job, I have a 2 and a half year old toddler which is a lot more time consuming than the job). |
5 participants
(issue #714) (#524)
This adds support for the "Energy saving" AC feature from the LG app.
I tested with my AC unit, "model": "RAC_056905_WW-RAC (AC)".