Skip to content

HTML in Sparkle appcast.xml should not be escaped #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mbacchi opened this issue Jun 10, 2020 · 0 comments
Open

HTML in Sparkle appcast.xml should not be escaped #364

mbacchi opened this issue Jun 10, 2020 · 0 comments

Comments

@mbacchi
Copy link

mbacchi commented Jun 10, 2020

We've noticed that the Sparkle release notes are not rendered properly if HTML is provided in the omaha-server Release Notes field (issue here.)

Example of an appcast.xml:

<description>
<![CDATA[
Brave Browser version: 81.1.9.80 &lt;a href=&quot;https://github.com/brave/brave-browser/blob/master/CHANGELOG.md&quot;&gt;Brave Changelog&lt;/a&gt;
]]>
</description>

If HTML or a URL is provided in the release notes field, it should be passed into Sparkle without escape characters.

One such solution recommended by @mherrmann might be to use the Django safe template filter in the Sparkle appcast template here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbacchi