feat: implement notification interface

Author: recca0120

README.md

@@ -12,7 +12,7 @@
 [Omnipay](https://github.com/thephpleague/omnipay) is a framework agnostic, multi-gateway payment processing library for
 PHP 5.3+. This package implements ecpay support for Omnipay.
 
-**Note:** Replace `omnipay-taiwan`, `:author_name`, `recca0120`, `:author_website`, `:author_email`, `ecpay`
+**Note:** Replace `omnipay-taiwan`, `recca0120`, `recca0120`, `recca0120@gmail.com`, `ecpay`
 , `:package_description` and `ecpay` with their correct values in [README.md](README.md)
 , [CHANGELOG.md](CHANGELOG.md), [CONTRIBUTING.md](CONTRIBUTING.md), [LICENSE.md](LICENSE.md)
 and [composer.json](composer.json) files, then delete this line.
@@ -65,11 +65,11 @@ Please see [CONTRIBUTING](CONTRIBUTING.md) for details.
 
 ## Security
 
-If you discover any security related issues, please email :author_email instead of using the issue tracker.
+If you discover any security related issues, please email recca0120@gmail.com instead of using the issue tracker.
 
 ## Credits
 
-- [:author_name](https://github.com/recca0120)
+- [recca0120](https://github.com/recca0120)
 - [All Contributors](../../contributors)
 
 ## License

src/Message/CompletePurchaseRequest.php

@@ -4,12 +4,13 @@
 
 use Omnipay\Common\Exception\InvalidRequestException;
 use Omnipay\Common\Message\AbstractRequest;
+use Omnipay\Common\Message\NotificationInterface;
 use Omnipay\ECPay\Traits\HasCustomFields;
 use Omnipay\ECPay\Traits\HasDefaults;
 use Omnipay\ECPay\Traits\HasMerchantTradeNo;
 use Omnipay\ECPay\Traits\HasStoreID;
 
-class CompletePurchaseRequest extends AbstractRequest
+class CompletePurchaseRequest extends AbstractRequest implements NotificationInterface
 {
     use HasDefaults;
     use HasMerchantTradeNo;
@@ -223,4 +224,22 @@ public function sendData($data)
     {
         return $this->response = new CompletePurchaseResponse($this, $data);
     }
+
+    public function getTransactionStatus()
+    {
+        return $this->getNotification()->getTransactionStatus();
+    }
+
+    public function getMessage()
+    {
+        return $this->getNotification()->getMessage();
+    }
+
+    /**
+     * @return NotificationInterface
+     */
+    private function getNotification()
+    {
+        return ! $this->response ? $this->send() : $this->response;
+    }
 }

tests/Message/AcceptNotificationRequestTest.php

@@ -3,6 +3,7 @@
 namespace Omnipay\ECPay\Tests\Message;
 
 use Omnipay\Common\Exception\InvalidRequestException;
+use Omnipay\Common\Message\NotificationInterface;
 use Omnipay\ECPay\Message\AcceptNotificationRequest;
 use Omnipay\Tests\TestCase;
 
@@ -44,21 +45,20 @@ public function testGetData()
 
         self::assertEquals($options, $request->getData());
 
-        return [$request->send(), $options];
+        return [$request, $options];
     }
 
     /**
      * @depends testGetData
-     * @param $result
+     * @param $results
      */
-    public function testSendData($result)
+    public function testSendData($results)
     {
-        list($response, $options) = $result;
+        list($notification, $options) = $results;
 
-        self::assertTrue($response->isSuccessful());
-        self::assertEquals('1|OK', $response->getMessage());
-        self::assertEquals($options['RtnCode'], $response->getCode());
-        self::assertEquals($options['TradeNo'], $response->getTransactionReference());
-        self::assertEquals($options['MerchantTradeNo'], $response->getTransactionId());
+        self::assertEquals($options['MerchantTradeNo'], $notification->getTransactionId());
+        self::assertEquals($options['TradeNo'], $notification->getTransactionReference());
+        self::assertEquals(NotificationInterface::STATUS_COMPLETED, $notification->getTransactionStatus());
+        self::assertEquals('1|OK', $notification->getMessage());
     }
 }