Skip to content

Conversation

awpala
Copy link
Contributor

@awpala awpala commented Aug 21, 2024

Changes are primarily in new/added /website/functions, and correspondingly updated /website/firebase.json. Other changes are primarily due to running formatter.

@awpala awpala added the enhancement New feature or request label Aug 21, 2024
@awpala awpala added this to the 2.0 - Refinement milestone Aug 21, 2024
@awpala awpala requested a review from tran-christian August 21, 2024 22:15
@awpala awpala self-assigned this Aug 21, 2024
Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2024 4:36am

@github-actions github-actions bot added documentation Improvements or additions to documentation root AnyChange release source labels Aug 21, 2024
);
setLoading(false);
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [selectedYear, selectedSemester]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has missing dependencies: 'courseId', 'courseTimeline', and 'mutate'. Either include them or remove the dependency array.
editorRef?.current?.getInstance().setMarkdown(initialValue);
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [editorRef?.current?.getInstance().getMarkdown(), initialValue]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked.

type TSemesterMap = {
// eslint-disable-next-line no-unused-vars
[semesterId in TSemesterId]: Date;

Check warning

Code scanning / ESLint

disallow unused variables Warning

'semesterId' is defined but never used.
omshub-admin
omshub-admin previously approved these changes Aug 25, 2024
@omshub-admin omshub-admin merged commit c4af2d5 into main Aug 25, 2024
15 checks passed
@omshub-admin omshub-admin deleted the init-cloud-functions branch August 25, 2024 04:38
omshub-admin added a commit that referenced this pull request Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants