[PTX] Enable migration of ldmatrix #2692
Merged
+397
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiweij1
changed the title
tomflinda
reviewed
Mar 11, 2025
tomflinda
reviewed
Mar 11, 2025
tomflinda
reviewed
Mar 11, 2025
tomflinda
reviewed
Mar 11, 2025
TejaX-Alaghari
force-pushed
the
ptx
branch
5 times, most recently
from
bd88679 to
4492ec9
Compare
ziranzha
reviewed
Mar 14, 2025
ziranzha
reviewed
Mar 14, 2025
ziranzha
reviewed
Mar 14, 2025
ziranzha
reviewed
Mar 14, 2025
ziranzha
reviewed
Mar 20, 2025
TejaX-Alaghari
force-pushed
the
ptx
branch
2 times, most recently
from
de49c1d to
7f533ae
Compare
ziranzha
approved these changes
Mar 24, 2025
tomflinda
approved these changes
Apr 25, 2025
zhiweij1
approved these changes
Apr 25, 2025
| @@ -2055,6 +2055,103 @@ class joint_matrix { | |||
| matrix_accessor x; | |||
| const size_t num_elements; | |||
| }; | |||
|
|
|||
| /// Loads 1 8x8 b16 matrix from shared memory to local memory (32-bits per wi) | |||
There was a problem hiding this comment.
from local memory to private memory of each work item?
| } | ||
| } | ||
|
|
||
| /// Loads 2 8x8 b16 matrix from shared memory to local memory (32-bits per wi) |
There was a problem hiding this comment.
Please use sycl language in the comments.
| @@ -2055,6 +2055,98 @@ class joint_matrix { | |||
| matrix_accessor x; | |||
| const size_t num_elements; | |||
| }; | |||
|
|
|||
| /// Loads 1 8x8 b16 matrix from local memory to private memory (32-bits per wi) | |||
There was a problem hiding this comment.
Suggested change
| /// Loads 1 8x8 b16 matrix from local memory to private memory (32-bits per wi) | |
| /// Loads 1 8x8 b16 matrix from local memory to private memory (32-bits per work item) |
There was a problem hiding this comment.
Please give more details on how the loaded data will be distributed on private memory. is it a work-group function or sub-group function? Make sure user can use it after reading the comments.
TejaX-Alaghari
force-pushed
the
ptx
branch
2 times, most recently
from
0463353 to
63ffbaf
Compare
TejaX-Alaghari
force-pushed
the
ptx
branch
4 times, most recently
from
22018c1 to
df279d5
Compare
zhimingwang36
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the migration of ldmatrix PTX ASM API