[disjoint] Add CTL memory used/reserved metrics #1430
Closed
+347
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KFilipek
force-pushed
the
dj-used_reserve
branch
3 times, most recently
from
1e1ef90 to
e249023
Compare
bratpiorka
requested changes
Jul 11, 2025
KFilipek
force-pushed
the
dj-used_reserve
branch
4 times, most recently
from
d790924 to
64a80e4
Compare
bratpiorka
reviewed
Jul 11, 2025
bratpiorka
reviewed
Jul 11, 2025
KFilipek
force-pushed
the
dj-used_reserve
branch
from
64a80e4 to
1d25c21
Compare
bratpiorka
approved these changes
Jul 14, 2025
lplewa
reviewed
Jul 14, 2025
| (void)source, (void)indexes, (void)queryType, (void)extra_name; | ||
| disjoint_pool_t *pool = (disjoint_pool_t *)ctx; | ||
|
|
||
| if (arg == NULL || size < sizeof(size_t)) { |
There was a problem hiding this comment.
Does it really have to be an exact size? Isn't < enough?
lplewa
reviewed
Jul 14, 2025
| (void)source, (void)indexes, (void)queryType, (void)extra_name; | ||
| disjoint_pool_t *pool = (disjoint_pool_t *)ctx; | ||
|
|
||
| if (arg == NULL || size < sizeof(size_t)) { |
lplewa
reviewed
Jul 14, 2025
| } | ||
|
|
||
| static const umf_ctl_node_t CTL_NODE(disjoint)[] = { | ||
| CTL_LEAF_RW(name), CTL_LEAF_RO(used_memory), CTL_LEAF_RO(reserved_memory), |
There was a problem hiding this comment.
Used memory should be in the stats subtree
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist