Use plain Counter instead of CounterVec for the number of rate-limited transactions

Author: m-Peter

metrics/collector.go

@@ -82,10 +82,10 @@ var transactionsDroppedCounter = prometheus.NewCounter(prometheus.CounterOpts{
 	Help: "Total number of EVM transactions dropped due to service errors",
 })
 
-var eoaRateLimitedTransactions = prometheus.NewCounterVec(prometheus.CounterOpts{
-	Name: prefixedName("eoa_rate_limited_transactions"),
-	Help: "Total number of rate limited transactions by EOA",
-}, []string{"address"})
+var rateLimitedTransactionsCounter = prometheus.NewCounter(prometheus.CounterOpts{
+	Name: prefixedName("rate_limited_transactions_total"),
+	Help: "Total number of rate-limited transactions",
+})
 
 var metrics = []prometheus.Collector{
 	apiErrors,
@@ -102,7 +102,7 @@ var metrics = []prometheus.Collector{
 	blockIngestionTime,
 	requestRateLimitedCounters,
 	transactionsDroppedCounter,
-	eoaRateLimitedTransactions,
+	rateLimitedTransactionsCounter,
 }
 
 type Collector interface {
@@ -119,28 +119,28 @@ type Collector interface {
 	BlockIngestionTime(blockCreation time.Time)
 	RequestRateLimited(method string)
 	TransactionsDropped(count int)
-	EOARateLimited(address string)
+	TransactionRateLimited()
 }
 
 var _ Collector = &DefaultCollector{}
 
 type DefaultCollector struct {
 	// TODO: for now we cannot differentiate which api request failed number of times
-	apiErrorsCounter           prometheus.Counter
-	serverPanicsCounters       *prometheus.CounterVec
-	cadenceBlockHeight         prometheus.Gauge
-	evmBlockHeight             prometheus.Gauge
-	evmBlockIndexedCounter     prometheus.Counter
-	evmTxIndexedCounter        prometheus.Counter
-	operatorBalance            prometheus.Gauge
-	evmAccountCallCounters     *prometheus.CounterVec
-	requestDurations           *prometheus.HistogramVec
-	availableSigningkeys       prometheus.Gauge
-	gasEstimationIterations    prometheus.Gauge
-	blockIngestionTime         prometheus.Histogram
-	requestRateLimitedCounters *prometheus.CounterVec
-	transactionsDroppedCounter prometheus.Counter
-	eoaRateLimitedTransactions *prometheus.CounterVec
+	apiErrorsCounter               prometheus.Counter
+	serverPanicsCounters           *prometheus.CounterVec
+	cadenceBlockHeight             prometheus.Gauge
+	evmBlockHeight                 prometheus.Gauge
+	evmBlockIndexedCounter         prometheus.Counter
+	evmTxIndexedCounter            prometheus.Counter
+	operatorBalance                prometheus.Gauge
+	evmAccountCallCounters         *prometheus.CounterVec
+	requestDurations               *prometheus.HistogramVec
+	availableSigningkeys           prometheus.Gauge
+	gasEstimationIterations        prometheus.Gauge
+	blockIngestionTime             prometheus.Histogram
+	requestRateLimitedCounters     *prometheus.CounterVec
+	transactionsDroppedCounter     prometheus.Counter
+	rateLimitedTransactionsCounter prometheus.Counter
 }
 
 func NewCollector(logger zerolog.Logger) Collector {
@@ -150,21 +150,21 @@ func NewCollector(logger zerolog.Logger) Collector {
 	}
 
 	return &DefaultCollector{
-		apiErrorsCounter:           apiErrors,
-		serverPanicsCounters:       serverPanicsCounters,
-		cadenceBlockHeight:         cadenceBlockHeight,
-		evmBlockHeight:             evmBlockHeight,
-		evmBlockIndexedCounter:     evmBlockIndexedCounter,
-		evmTxIndexedCounter:        evmTxIndexedCounter,
-		evmAccountCallCounters:     evmAccountCallCounters,
-		requestDurations:           requestDurations,
-		operatorBalance:            operatorBalance,
-		availableSigningkeys:       availableSigningKeys,
-		gasEstimationIterations:    gasEstimationIterations,
-		blockIngestionTime:         blockIngestionTime,
-		requestRateLimitedCounters: requestRateLimitedCounters,
-		transactionsDroppedCounter: transactionsDroppedCounter,
-		eoaRateLimitedTransactions: eoaRateLimitedTransactions,
+		apiErrorsCounter:               apiErrors,
+		serverPanicsCounters:           serverPanicsCounters,
+		cadenceBlockHeight:             cadenceBlockHeight,
+		evmBlockHeight:                 evmBlockHeight,
+		evmBlockIndexedCounter:         evmBlockIndexedCounter,
+		evmTxIndexedCounter:            evmTxIndexedCounter,
+		evmAccountCallCounters:         evmAccountCallCounters,
+		requestDurations:               requestDurations,
+		operatorBalance:                operatorBalance,
+		availableSigningkeys:           availableSigningKeys,
+		gasEstimationIterations:        gasEstimationIterations,
+		blockIngestionTime:             blockIngestionTime,
+		requestRateLimitedCounters:     requestRateLimitedCounters,
+		transactionsDroppedCounter:     transactionsDroppedCounter,
+		rateLimitedTransactionsCounter: rateLimitedTransactionsCounter,
 	}
 }
 
@@ -243,10 +243,8 @@ func (c *DefaultCollector) TransactionsDropped(count int) {
 	c.transactionsDroppedCounter.Add(float64(count))
 }
 
-func (c *DefaultCollector) EOARateLimited(address string) {
-	c.eoaRateLimitedTransactions.
-		With(prometheus.Labels{"address": address}).
-		Inc()
+func (c *DefaultCollector) TransactionRateLimited() {
+	c.rateLimitedTransactionsCounter.Inc()
 }
 
 func prefixedName(name string) string {

metrics/nop.go

@@ -25,4 +25,4 @@ func (c *nopCollector) GasEstimationIterations(count int)          {}
 func (c *nopCollector) BlockIngestionTime(blockCreation time.Time) {}
 func (c *nopCollector) RequestRateLimited(method string)           {}
 func (c *nopCollector) TransactionsDropped(count int)              {}
-func (c *nopCollector) EOARateLimited(address string)              {}
+func (c *nopCollector) TransactionRateLimited()                    {}

services/requester/requester.go

@@ -219,7 +219,7 @@ func (e *EVM) SendRawTransaction(ctx context.Context, data []byte) (common.Hash,
 			return common.Hash{}, fmt.Errorf("failed to check rate limit: %w", err)
 		}
 		if !ok {
-			e.collector.EOARateLimited(from.Hex())
+			e.collector.TransactionRateLimited()
 			return common.Hash{}, errs.ErrRateLimit
 		}
 	}