Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

feat: support on templating env for route inputs #8

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@

## Changelog

### latest

* feat: support on templating env for route inputs

### 1.4.2

* chore: bump fast-xml-parser from 4.0.11 to 4.2.4
Expand Down
3 changes: 3 additions & 0 deletions functions/ldap.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const LDAP = require('ldapjs');
const Logger = require('../lib/logger.js');
const Utils = require('../lib/utils.js');
const Qs = require('qs');
const helpers = require("../lib/helpers.js")

/**
*
Expand All @@ -14,6 +15,8 @@ exports.plugin = {
name: 'ldap',
register: async function (server) {
server.ext('onRequest', (request, h) => {
helpers.setQueryParameterTemplateValues(request.query);

let { tlsOptions, attributes } = request.query;

if (tlsOptions) {
Expand Down
16 changes: 16 additions & 0 deletions lib/helpers.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict';

require("dotenv").config();

const Handlebars = require("handlebars");

Handlebars.registerHelper('ENV', (value) => {
return new Handlebars.SafeString(value);
});

exports.setQueryParameterTemplateValues = (query) => {
for (const key of Object.keys(query)) {
const template = Handlebars.compile(query[key]);
query[key] = template(process.env);
}
}
8 changes: 8 additions & 0 deletions nodemon.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"ignore": ["tmp/", "node_modules/", "logs/", "test/"],
"ext": "js json env",
"watch": [
"*",
".env"
]
}
22 changes: 20 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
"@hapi/inert": "^7.0.0",
"@hapi/vision": "^7.0.0",
"activedirectory2": "^2.1.0",
"dotenv": "^16.3.1",
"fast-xml-parser": "^4.2.4",
"handlebars": "^4.7.7",
"hapi-swagger": "^15.0.0",
"joi": "^17.6.3",
"ldapjs": "^3.0.2",
Expand Down
24 changes: 24 additions & 0 deletions test/functions/ldap.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,4 +128,28 @@ describe('ldap:', () => {
expect(res.statusCode).to.equal(200);
expect(res.result.length === 5).to.equal(true);
});

it(`GET ${FUNCTION_ENDPOINT}/search - search result for query with environment variable placeholder in parameters - returns 200`, async () => {
const username = '%7B%7BENV databaseUser%7D%7D';
const password = '%7B%7BENV databasePassword%7D%7D';

const res = await server.inject({
method: 'GET',
url: `${FUNCTION_ENDPOINT}/search?url=${url}&username=${username}&password=${password}&base=${base}&filter=${filter}&scope=${scope}&paged=true&pageSize=5`,
});

expect(res.statusCode).to.equal(200);
});

it(`GET ${FUNCTION_ENDPOINT}/search - search result for query without using helper function on environment variable placeholder in parameters - returns 401`, async () => {
const username = '%7B%7BdatabaseUser%7D%7D';
const password = '%7B%7BdatabasePassword%7D%7D';

const res = await server.inject({
method: 'GET',
url: `${FUNCTION_ENDPOINT}/search?url=${url}&username=${username}&password=${password}&base=${base}&filter=${filter}&scope=${scope}&paged=true&pageSize=5`,
});

expect(res.statusCode).to.equal(401);
});
});