feat: support on templating env for route inputs

app.js

@@ -1,18 +1,48 @@
 'use strict';
 
+const fs = require('fs');
+const path = require('path');
 const Logger = require('./lib/logger.js');
 const SetupApp = require('./lib/setupApp');
 const { version } = require('./package.json');
 
 const serverPromise = SetupApp();
 
+const cwd = process.cwd();
+const NODE_ENV = process.env.NODE_ENV || 'development';
+const CONFIG_BASE_PATH = process.env.CONFIG_BASE_PATH || './config';
+const configFileName = `${NODE_ENV}.json`;
+
+let configPath;
+if (path.isAbsolute(CONFIG_BASE_PATH)) {
+  configPath = path.normalize(CONFIG_BASE_PATH) + path.sep + configFileName;
+} else {
+  configPath = CONFIG_BASE_PATH.replace(/\/$/, '/') + '/' + configFileName;
+}
+
 module.exports = serverPromise;
 module.exports.start = start;
 
 if (require.main === module) {
+  validateConfig();
   start();
 }
 
+function validateConfig() {
+  try {
+    fs.statSync(path.relative(cwd, configPath));
+    require(configPath);
+  } catch (err) {
+    if (err.code === 'ENOENT') {
+      const msg = `Could not find configuration file for environment ${NODE_ENV}`;
+      console.log('FATAL', msg);
+      console.log('FATAL', 'Set NODE_ENV to production or development or add', configPath);
+      throw new Error(msg);
+    }
+    throw new Error(err.message);
+  }
+}
+
 function start() {
   serverPromise.then((server) => {
     process.once('SIGTERM', terminate);

config/development.json

@@ -0,0 +1,6 @@
+{
+    "ldap": {
+        "databaseUser": "OVERRIDE_IN_ENV",
+        "databasePassword": "OVERRIDE_IN_ENV"
+    }
+}

config/production.json

@@ -0,0 +1,6 @@
+{
+  "ldap": {
+    "databaseUser": "OVERRIDE_IN_ENV",
+    "databasePassword": "OVERRIDE_IN_ENV"
+  }
+}

config/test.json

@@ -0,0 +1,7 @@
+{
+    "ldap": {
+        "databaseUser": "cn=read-only-admin,dc=example,dc=com",
+        "databasePassword": "password",
+        "url": "ldap%3A%2F%2Fldap.forumsys.com"
+    }
+}

functions/ldap.js

@@ -5,6 +5,8 @@ const LDAP = require('ldapjs');
 const Logger = require('../lib/logger.js');
 const Utils = require('../lib/utils.js');
 const Qs = require('qs');
+const config = require('exp-config');
+const helpers = require("../lib/helpers.js")
 
 /**
  *
@@ -14,6 +16,8 @@ exports.plugin = {
   name: 'ldap',
   register: async function (server) {
     server.ext('onRequest', (request, h) => {
+      helpers.setQueryParameterTemplateValues(request.query, config.ldap);
+
       let { tlsOptions, attributes } = request.query;
 
       if (tlsOptions) {

lib/helpers.js

@@ -0,0 +1,14 @@
+'use strict';
+
+const Handlebars = require("handlebars");
+
+Handlebars.registerHelper('ENV', (value) => {
+    return new Handlebars.SafeString(value);
+});
+
+exports.setQueryParameterTemplateValues = (query, context) => {
+    for (const key of Object.keys(query)) {
+        const template = Handlebars.compile(query[key]);
+        query[key] = template(context);
+    }
+}

nodemon.json

@@ -0,0 +1,9 @@
+{
+  "ignore": ["tmp/", "node_modules/", "logs/", "test/"],
+  "ext": "js json env",
+  "watch": ["*", ".env"],
+  "env": {
+    "ENV_PREFIX": "ONIFY_",
+    "INTERPRET_CHAR_AS_DOT": "_"
+  }
+}

package.json

@@ -25,7 +25,9 @@
     "@hapi/inert": "^7.0.0",
     "@hapi/vision": "^7.0.0",
     "activedirectory2": "^2.1.0",
+    "exp-config": "^4.2.1",
     "fast-xml-parser": "^4.2.4",
+    "handlebars": "^4.7.7",
     "hapi-swagger": "^15.0.0",
     "joi": "^17.6.3",
     "ldapjs": "^3.0.2",

test/functions/ldap.js

@@ -128,4 +128,28 @@ describe('ldap:', () => {
     expect(res.statusCode).to.equal(200);
     expect(res.result.length === 5).to.equal(true);
   });
+
+  it(`GET ${FUNCTION_ENDPOINT}/search - search result for query with environment variable placeholder in parameters - returns 200`, async () => {
+    const username = '%7B%7BENV databaseUser%7D%7D';
+    const password = '%7B%7BENV databasePassword%7D%7D';
+
+    const res = await server.inject({
+      method: 'GET',
+      url: `${FUNCTION_ENDPOINT}/search?url=${url}&username=${username}&password=${password}&base=${base}&filter=${filter}&scope=${scope}&paged=true&pageSize=5`,
+    });
+
+    expect(res.statusCode).to.equal(200);
+  });
+
+  it(`GET ${FUNCTION_ENDPOINT}/search - search result for query without using helper function on environment variable placeholder in parameters - returns 200`, async () => {
+    const username = '%7B%7BdatabaseUser%7D%7D';
+    const password = '%7B%7BdatabasePassword%7D%7D';
+
+    const res = await server.inject({
+      method: 'GET',
+      url: `${FUNCTION_ENDPOINT}/search?url=${url}&username=${username}&password=${password}&base=${base}&filter=${filter}&scope=${scope}&paged=true&pageSize=5`,
+    });
+
+    expect(res.statusCode).to.equal(401);
+  });
 });