Skip to content

Added warning in the chat input that links won't work #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SoloDevAbu
Copy link
Contributor

@SoloDevAbu SoloDevAbu commented Apr 17, 2025

Description

Added warning in the chat input that links with www.*****.com or anything with https:// won't work

Related Issues

fixes #1649

Testing

Tested by running locally

Screenshots (if applicable)

linkwarning


Important

Adds warning to chat input placeholder that links won't work in translation.json and messages/en.json.

  • Behavior:
    • Adds warning to chat input placeholder in translation.json and messages/en.json that links (e.g., www.*****.com or https://) won't work.

This description was created by Ellipsis for 0058895. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0058895 in 1 minute and 2 seconds

More details
  • Looked at 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. apps/studio/src/locales/en/translation.json:71
  • Draft comment:
    Consider rewording the warning text. For clarity, a phrasing like "Links (e.g., www.example.com or any URL starting with https://) won’t work." might improve readability. Also, adding a tooltip instead of a newline in a placeholder might be more user-friendly.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
2. apps/web/client/messages/en.json:71
  • Draft comment:
    Consider aligning the warning text wording. A clearer message such as "Links (e.g., www.example.com or any URL starting with https://) won’t work." may be more intuitive.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
3. apps/studio/src/locales/en/translation.json:71
  • Draft comment:
    Consider rewording the warning—for clarity use an example like 'example.com' instead of '*****', and ensure that the newline character in the placeholder is supported.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
4. apps/web/client/messages/en.json:71
  • Draft comment:
    Consider clarifying the warning text (e.g., use 'example.com' instead of '*****') and verify newline support in placeholder fields.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
5. apps/web/client/messages/en.json:71
  • Draft comment:
    Consider capitalizing the first letter of the appended sentence in the placeholder text (i.e., 'Link (www.*****.com or anything with an https://) won't work.') to improve consistency.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50%
    This is a pure UI/styling suggestion about text capitalization. The comment doesn't point out any functional issues or code quality problems. It's a minor stylistic preference that doesn't materially impact the user experience. Looking at the rest of the file, there isn't even a clear capitalization pattern for similar messages.
    Maybe there's a style guide that requires consistent capitalization in UI messages? Maybe inconsistent capitalization could confuse users?
    Even if there is a style guide, this kind of minor UI text formatting should be handled through team discussion or documentation, not PR comments. The impact on users would be negligible.
    Delete this comment as it violates the rule about not commenting on pure UI/styling changes. The comment is too minor and doesn't address any real issues.

Workflow ID: wflow_sLHOyRpJLGEC8vug


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Warn users that inputting links won't work
1 participant