Use biome as linter

.github/workflows/test.yml

@@ -6,66 +6,90 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
-      - uses: actions/setup-node@v3
+      - uses: pnpm/action-setup@v4
+        name: Install pnpm
         with:
-          node-version: 16
-          cache: yarn
+          version: 9
+          run_install: false
 
-      - run: yarn install --frozen-lockfile
-      - run: yarn test
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 18
+          cache: pnpm
+
+      - run: pnpm install --frozen-lockfile
+      - run: pnpm test
 
   build-minimal:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
+
+      - uses: pnpm/action-setup@v4
+        name: Install pnpm
+        with:
+          version: 9
+          run_install: false
 
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: 16
-          cache: yarn
+          node-version: 18
+          cache: pnpm
 
-      - run: yarn install --frozen-lockfile
-      - run: yarn build
+      - run: pnpm install --frozen-lockfile
+      - run: pnpm build
 
       - name: Build minimal example
         run: |
           cd examples/minimal
-          yarn build
+          pnpm build
 
   build-full:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
-      - uses: actions/setup-node@v3
+      - uses: pnpm/action-setup@v4
+        name: Install pnpm
         with:
-          node-version: 16
-          cache: yarn
+          version: 9
+          run_install: false
 
-      - run: yarn install --frozen-lockfile
-      - run: yarn build
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 18
+          cache: pnpm
+
+      - run: pnpm install --frozen-lockfile
+      - run: pnpm build
 
       - name: Build full example
         run: |
           cd examples/full
-          yarn build
+          pnpm build
 
   # TODO: using the official API with GitHub Actions results in too much rate
   # limiting and false negative build failures, so we're disabling it for now.
   # build-full-official-api:
   #   runs-on: ubuntu-latest
   #   steps:
-  #     - uses: actions/checkout@v3
+  #     - uses: actions/checkout@v4
+
+  #     - uses: pnpm/action-setup@v4
+  #       name: Install pnpm
+  #       with:
+  #         version: 9
+  #         run_install: false
 
-  #     - uses: actions/setup-node@v3
+  #     - uses: actions/setup-node@v4
   #       with:
   #         node-version: 16
-  #         cache: yarn
+  #         cache: pnpm
 
-  #     - run: yarn install --frozen-lockfile
-  #     - run: yarn build
+  #     - run: pnpm install --frozen-lockfile
+  #     - run: pnpm build
 
   #     - name: Build full example using the official Notion API
 
@@ -75,4 +99,4 @@ jobs:
 
   #       run: |
   #         cd examples/full
-  #         yarn build
+  #         pnpm build

.gitignore

@@ -8,6 +8,9 @@ build
 dist
 types
 
+# Typescript builds
+packages/*/.tsimp
+
 # misc
 .DS_Store
 .env

.mise.toml

@@ -0,0 +1,17 @@
+[tools]
+# There was a moment when Notion search API was broken
+# It was fixed directly in react-notion-x dependency
+# When trying to replace the dependency I tried to run
+# $ brew install vips
+# $ yarn add https://github.com/NotionX/react-notion-x#v6.16.2
+# There's weird errors if one is building react-notion-x directly from github
+# 'ValueError: invalid mode: 'rU' while trying to load binding.gyp'
+# These should be fixed by downgrading python to 3.10
+# Source: https://stackoverflow.com/a/74732671
+python = ['3.10']
+
+# The node-gyp module doesn't work properly when using node 20
+# TypeError: Cannot assign to read only property 'cflags' of object '#<Object>'
+# See more: https://stackoverflow.com/a/77910474/1337062
+node = ['20']
+"npm:pnpm" = '8.11.0'

biome.json

@@ -0,0 +1,63 @@
+{
+	"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
+	"vcs": {
+		"enabled": true,
+		"clientKind": "git",
+		"useIgnoreFile": true
+	},
+	"files": {
+		"ignoreUnknown": false,
+		"ignore": []
+	},
+	"formatter": {
+		"enabled": true,
+		"indentStyle": "tab"
+	},
+	"organizeImports": {
+		"enabled": true
+	},
+	"linter": {
+		"enabled": true,
+		"rules": {
+			"recommended": true,
+			"suspicious": {
+				"noExplicitAny": "off",
+				"noImplicitAnyLet": "off",
+				"noArrayIndexKey": "off",
+				"noDuplicateFontNames": "off"
+			},
+			"a11y": {
+				"useAltText": "off",
+				"useKeyWithClickEvents": "off",
+				"useFocusableInteractive": "off",
+				"useMediaCaption": "off",
+				"noSvgWithoutTitle": "off",
+				"useGenericFontNames": "off",
+				"useButtonType": "off",
+				"useSemanticElements": "off"
+			},
+			"correctness": {
+				"useExhaustiveDependencies": "off",
+				"noConstantCondition": "off"
+			},
+			"style": {
+				"noParameterAssign": "off",
+				"noNonNullAssertion": "off"
+			},
+			"performance": {
+				"noAccumulatingSpread": "off"
+			},
+			"security": {
+				"noDangerouslySetInnerHtml": "off"
+			},
+			"complexity": {
+				"noForEach": "off"
+			}
+		}
+	},
+	"javascript": {
+		"formatter": {
+			"quoteStyle": "double"
+		}
+	}
+}

examples/cra/package.json

@@ -1,42 +1,32 @@
 {
-  "name": "notion-x-example-cra",
-  "version": "6.16.0",
-  "private": true,
-  "scripts": {
-    "start": "GENERATE_SOURCEMAP=false react-scripts start",
-    "build": "GENERATE_SOURCEMAP=false react-scripts build",
-    "dev": "GENERATE_SOURCEMAP=false react-scripts start",
-    "eject": "GENERATE_SOURCEMAP=false react-scripts eject",
-    "lint": "eslint \"src/**/*.ts*\"",
-    "clean": "rm -rf build"
-  },
-  "dependencies": {
-    "@types/node": "^16.11.26",
-    "@types/react": "^17.0.43",
-    "@types/react-dom": "^17.0.14",
-    "notion-types": "workspace:*",
-    "react": "^17.0.2",
-    "react-dom": "^17.0.2",
-    "react-notion-x": "workspace:*",
-    "react-scripts": "5.0.0",
-    "typescript": "^4.6.3"
-  },
-  "eslintConfig": {
-    "extends": [
-      "react-app",
-      "react-app/jest"
-    ]
-  },
-  "browserslist": {
-    "production": [
-      ">0.2%",
-      "not dead",
-      "not op_mini all"
-    ],
-    "development": [
-      "last 1 chrome version",
-      "last 1 firefox version",
-      "last 1 safari version"
-    ]
-  }
+	"name": "notion-x-example-cra",
+	"version": "6.16.1",
+	"private": true,
+	"scripts": {
+		"start": "GENERATE_SOURCEMAP=false react-scripts start",
+		"build": "GENERATE_SOURCEMAP=false react-scripts build",
+		"dev": "GENERATE_SOURCEMAP=false react-scripts start",
+		"eject": "GENERATE_SOURCEMAP=false react-scripts eject",
+		"lint": "biome check",
+		"clean": "rm -rf build"
+	},
+	"dependencies": {
+		"@types/node": "^16.11.26",
+		"@types/react": "^17.0.43",
+		"@types/react-dom": "^17.0.14",
+		"notion-types": "workspace:*",
+		"react": "^17.0.2",
+		"react-dom": "^17.0.2",
+		"react-notion-x": "workspace:*",
+		"react-scripts": "5.0.0",
+		"typescript": "^4.6.3"
+	},
+	"browserslist": {
+		"production": [">0.2%", "not dead", "not op_mini all"],
+		"development": [
+			"last 1 chrome version",
+			"last 1 firefox version",
+			"last 1 safari version"
+		]
+	}
 }

examples/cra/public/manifest.json

@@ -1,25 +1,25 @@
 {
-  "short_name": "React App",
-  "name": "Create React App Sample",
-  "icons": [
-    {
-      "src": "favicon.ico",
-      "sizes": "64x64 32x32 24x24 16x16",
-      "type": "image/x-icon"
-    },
-    {
-      "src": "logo192.png",
-      "type": "image/png",
-      "sizes": "192x192"
-    },
-    {
-      "src": "logo512.png",
-      "type": "image/png",
-      "sizes": "512x512"
-    }
-  ],
-  "start_url": ".",
-  "display": "standalone",
-  "theme_color": "#000000",
-  "background_color": "#ffffff"
+	"short_name": "React App",
+	"name": "Create React App Sample",
+	"icons": [
+		{
+			"src": "favicon.ico",
+			"sizes": "64x64 32x32 24x24 16x16",
+			"type": "image/x-icon"
+		},
+		{
+			"src": "logo192.png",
+			"type": "image/png",
+			"sizes": "192x192"
+		},
+		{
+			"src": "logo512.png",
+			"type": "image/png",
+			"sizes": "512x512"
+		}
+	],
+	"start_url": ".",
+	"display": "standalone",
+	"theme_color": "#000000",
+	"background_color": "#ffffff"
 }