Skip to content

Minor doc and go vet fixes #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Minor doc and go vet fixes #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a705b62
docs: fix for contributing instructions
carldunham Jul 14, 2018
699fdc3
fix: for `go vet` to pass
carldunham Jul 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ Thanks for supporting Ginkgo!
Fork the repo, then:

```
go get https://github.com/onsi/ginkgo
go get github.com/onsi/ginkgo
go get github.com/onsi/gomega/...
cd $GOPATH/onsi/ginkgo
cd $GOPATH/src/github.com/onsi/ginkgo
git remote add fork git@github.com:<NAME>/ginkgo.git

ginkgo -r -p # ensure tests are green
Expand Down
5 changes: 2 additions & 3 deletions ginkgo/testrunner/test_runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,9 +367,8 @@ func (t *TestRunner) runParallelGinkgoSuite() RunResult {
| |
| Ginkgo timed out waiting for all parallel nodes to report back! |
| |
-------------------------------------------------------------------
`)
fmt.Println(t.Suite.PackageName, "timed out. path:", t.Suite.Path)
-------------------------------------------------------------------`)
fmt.Println("\n", t.Suite.PackageName, "timed out. path:", t.Suite.Path)
os.Stdout.Sync()

for _, writer := range writers {
Expand Down