fix: ensure exception strings don't get swallowed (#5192)

* ensure exception strings don't get swallowed

* just send exception code

Author: evan-onyx

backend/onyx/background/celery/tasks/docfetching/tasks.py

@@ -295,7 +295,11 @@ def process_job_result(
         if result.exit_code is not None:
             result.status = IndexingWatchdogTerminalStatus.from_code(result.exit_code)
 
-        result.exception_str = job.exception()
+        job_level_exception = job.exception()
+        result.exception_str = (
+            f"Docfetching returned exit code {result.exit_code} "
+            f"with exception: {job_level_exception}"
+        )
 
     return result
 

backend/onyx/background/indexing/job_client.py

@@ -153,10 +153,9 @@ def exception(self) -> str:
         if self._exception is None and self.queue and not self.queue.empty():
             self._exception = self.queue.get()  # Get exception from queue
 
-        if self._exception:
-            return self._exception
-
-        return f"Job with ID '{self.id}' did not report an exception."
+        return (
+            self._exception or f"Job with ID '{self.id}' did not report an exception."
+        )
 
 
 class SimpleJobClient: