adding SINGLE/LIST values to new tag_type column

Author: joachim-danswer

backend/alembic/versions/2a04911f3c9f_tag_type_column.py

@@ -0,0 +1,32 @@
+"""tag_type_column
+
+Revision ID: 2a04911f3c9f
+Revises: 3fc5d75723b3
+Create Date: 2025-08-01 15:32:06.453072
+
+"""
+
+from alembic import op
+import sqlalchemy as sa
+
+
+# revision identifiers, used by Alembic.
+revision = "2a04911f3c9f"
+down_revision = "3fc5d75723b3"
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    op.add_column(
+        "tag",
+        sa.Column(
+            "tag_type",
+            sa.Enum("single", "list", name="tagtype", native_enum=False),
+            nullable=True,
+        ),
+    )
+
+
+def downgrade() -> None:
+    op.drop_column("tag", "tag_type")

backend/onyx/configs/constants.py

@@ -195,6 +195,11 @@ class DocumentSource(str, Enum):
     MOCK_CONNECTOR = "mock_connector"
 
 
+class TagType(str, Enum):
+    SINGLE = "single"
+    LIST = "list"
+
+
 class FederatedConnectorSource(str, Enum):
     FEDERATED_SLACK = "federated_slack"
 

backend/onyx/db/models.py

@@ -50,6 +50,7 @@
     MilestoneRecordType,
 )
 from onyx.configs.constants import DocumentSource
+from onyx.configs.constants import TagType
 from onyx.configs.constants import FileOrigin
 from onyx.configs.constants import MessageType
 from onyx.db.enums import (
@@ -1293,6 +1294,9 @@ class Tag(Base):
     source: Mapped[DocumentSource] = mapped_column(
         Enum(DocumentSource, native_enum=False)
     )
+    tag_type: Mapped[TagType] = mapped_column(
+        Enum(TagType, native_enum=False), nullable=True
+    )
 
     documents = relationship(
         "Document",

backend/onyx/db/tag.py

@@ -7,6 +7,7 @@
 from sqlalchemy.orm import Session
 
 from onyx.configs.constants import DocumentSource
+from onyx.configs.constants import TagType
 from onyx.db.models import Document
 from onyx.db.models import Document__Tag
 from onyx.db.models import Tag
@@ -58,9 +59,17 @@ def create_or_add_document_tag(
     tag = db_session.execute(tag_stmt).scalar_one_or_none()
 
     if not tag:
-        tag = Tag(tag_key=tag_key, tag_value=tag_value, source=source)
+        tag = Tag(
+            tag_key=tag_key,
+            tag_value=tag_value,
+            source=source,
+            tag_type=TagType.SINGLE,
+        )
         db_session.add(tag)
 
+    elif tag.tag_type is None:
+        tag.tag_type = TagType.SINGLE
+
     if tag not in document.tags:
         document.tags.append(tag)
 
@@ -107,10 +116,23 @@ def create_or_add_document_tag_list(
     new_tags = []
     for tag_value in valid_tag_values:
         if tag_value not in existing_tag_values:
-            new_tag = Tag(tag_key=tag_key, tag_value=tag_value, source=source)
+            new_tag = Tag(
+                tag_key=tag_key,
+                tag_value=tag_value,
+                source=source,
+                tag_type=TagType.LIST,
+            )
             db_session.add(new_tag)
             new_tags.append(new_tag)
             existing_tag_values.add(tag_value)
+        else:
+            # Find the existing tag and update its type if needed
+            for existing_tag in existing_tags:
+                if (
+                    existing_tag.tag_value == tag_value
+                    and existing_tag.tag_type is None
+                ):
+                    existing_tag.tag_type = TagType.LIST
 
     if new_tags:
         logger.debug(