Address comments

Author: Weves

backend/onyx/configs/app_configs.py

@@ -360,8 +360,9 @@
 ENABLED_CONNECTOR_TYPES = os.environ.get("ENABLED_CONNECTOR_TYPES") or ""
 
 # If set to true, curators can only access and edit assistants that they created
-CURATORS_CANNOT_EDIT_NON_OWNED_ASSISTANTS = (
-    os.environ.get("CURATORS_CANNOT_EDIT_NON_OWNED_ASSISTANTS", "").lower() == "true"
+CURATORS_CANNOT_VIEW_OR_EDIT_NON_OWNED_ASSISTANTS = (
+    os.environ.get("CURATORS_CANNOT_VIEW_OR_EDIT_NON_OWNED_ASSISTANTS", "").lower()
+    == "true"
 )
 
 # Some calls to get information on expert users are quite costly especially with rate limiting

backend/onyx/db/persona.py

@@ -15,7 +15,7 @@
 from sqlalchemy.orm import Session
 
 from onyx.auth.schemas import UserRole
-from onyx.configs.app_configs import CURATORS_CANNOT_EDIT_NON_OWNED_ASSISTANTS
+from onyx.configs.app_configs import CURATORS_CANNOT_VIEW_OR_EDIT_NON_OWNED_ASSISTANTS
 from onyx.configs.app_configs import DISABLE_AUTH
 from onyx.configs.chat_configs import BING_API_KEY
 from onyx.configs.chat_configs import CONTEXT_CHUNKS_ABOVE
@@ -98,11 +98,11 @@ def _add_user_filters(
         return stmt.where(where_clause)
 
     # If curator ownership restriction is enabled, curators can only access their own assistants
-    if CURATORS_CANNOT_EDIT_NON_OWNED_ASSISTANTS and user.role in [
+    if CURATORS_CANNOT_VIEW_OR_EDIT_NON_OWNED_ASSISTANTS and user.role in [
         UserRole.CURATOR,
         UserRole.GLOBAL_CURATOR,
     ]:
-        where_clause = Persona.user_id == user.id
+        where_clause = (Persona.user_id == user.id) | (Persona.user_id.is_(None))
         return stmt.where(where_clause)
 
     where_clause = User__UserGroup.user_id == user.id