Skip to content

Commit dac2638

Browse files
authored
Revert "fix: update contribution guide (#5354)"
This reverts commit 224a70e.
1 parent 224a70e commit dac2638

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

CONTRIBUTING_VSCODE.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ This guide explains how to set up and use VSCode's debugging capabilities with t
55
## Initial Setup
66

77
1. **Environment Setup**:
8-
- Copy `.vscode/env_template.txt` to `.vscode/.env`
8+
- Copy `.vscode/.env.template` to `.vscode/.env`
99
- Fill in the necessary environment variables in `.vscode/.env`
1010
2. **launch.json**:
1111
- Copy `.vscode/launch.template.jsonc` to `.vscode/launch.json`
@@ -17,9 +17,10 @@ Before starting, make sure the Docker Daemon is running.
1717
1. Open the Debug view in VSCode (Cmd+Shift+D on macOS)
1818
2. From the dropdown at the top, select "Clear and Restart External Volumes and Containers" and press the green play button
1919
3. From the dropdown at the top, select "Run All Onyx Services" and press the green play button
20-
4. Now, you can navigate to onyx in your browser (default is http://localhost:3000) and start using the app
21-
5. You can set breakpoints by clicking to the left of line numbers to help debug while the app is running
22-
6. Use the debug toolbar to step through code, inspect variables, etc.
20+
4. CD into web, run "npm i" followed by npm run dev.
21+
5. Now, you can navigate to onyx in your browser (default is http://localhost:3000) and start using the app
22+
6. You can set breakpoints by clicking to the left of line numbers to help debug while the app is running
23+
7. Use the debug toolbar to step through code, inspect variables, etc.
2324

2425
## Features
2526

backend/onyx/configs/app_configs.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -842,12 +842,12 @@ def get_current_tz_offset() -> int:
842842
)
843843
S3_FILE_STORE_PREFIX = os.environ.get("S3_FILE_STORE_PREFIX") or "onyx-files"
844844
# S3_ENDPOINT_URL is for MinIO and other S3-compatible storage. Leave blank for AWS S3.
845-
S3_ENDPOINT_URL = os.environ.get("S3_ENDPOINT_URL") or "http://localhost:9004"
845+
S3_ENDPOINT_URL = os.environ.get("S3_ENDPOINT_URL")
846846
S3_VERIFY_SSL = os.environ.get("S3_VERIFY_SSL", "").lower() == "true"
847847

848848
# S3/MinIO Access Keys
849-
S3_AWS_ACCESS_KEY_ID = os.environ.get("S3_AWS_ACCESS_KEY_ID") or "minioadmin"
850-
S3_AWS_SECRET_ACCESS_KEY = os.environ.get("S3_AWS_SECRET_ACCESS_KEY") or "minioadmin"
849+
S3_AWS_ACCESS_KEY_ID = os.environ.get("S3_AWS_ACCESS_KEY_ID")
850+
S3_AWS_SECRET_ACCESS_KEY = os.environ.get("S3_AWS_SECRET_ACCESS_KEY")
851851

852852
# Forcing Vespa Language
853853
# English: en, German:de, etc. See: https://docs.vespa.ai/en/linguistics.html

0 commit comments

Comments
 (0)