Skip to content

Commit e6ddb25

Browse files
author
Richard Kuo (Danswer)
committed
Merge branch 'main' of https://github.com/danswer-ai/danswer into bugfix/xfail_bedrock
2 parents 48439e2 + 95ca592 commit e6ddb25

File tree

2 files changed

+30
-5
lines changed

2 files changed

+30
-5
lines changed

.github/workflows/docker-build-push-model-server-container-on-tag.yml

Lines changed: 29 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ on:
44
push:
55
tags:
66
- "*"
7-
paths:
8-
- 'backend/model_server/**'
9-
- 'backend/Dockerfile.model_server'
107

118
env:
129
REGISTRY_IMAGE: ${{ contains(github.ref_name, 'cloud') && 'onyxdotapp/onyx-model-server-cloud' || 'onyxdotapp/onyx-model-server' }}
@@ -15,7 +12,32 @@ env:
1512
BUILDKIT_PROGRESS: plain
1613

1714
jobs:
15+
# 1) Preliminary job to check if the changed files are relevant
16+
check_model_server_changes:
17+
runs-on: ubuntu-latest
18+
outputs:
19+
changed: ${{ steps.check.outputs.changed }}
20+
steps:
21+
- name: Checkout code
22+
uses: actions/checkout@v4
23+
24+
- name: Check if relevant files changed
25+
id: check
26+
run: |
27+
# Default to "false"
28+
echo "changed=false" >> $GITHUB_OUTPUT
29+
30+
# Compare the previous commit (github.event.before) to the current one (github.sha)
31+
# If any file in backend/model_server/** or backend/Dockerfile.model_server is changed,
32+
# set changed=true
33+
if git diff --name-only ${{ github.event.before }} ${{ github.sha }} \
34+
| grep -E '^backend/model_server/|^backend/Dockerfile.model_server'; then
35+
echo "changed=true" >> $GITHUB_OUTPUT
36+
fi
37+
1838
build-amd64:
39+
needs: [check_model_server_changes]
40+
if: needs.check_model_server_changes.outputs.changed == 'true'
1941
runs-on:
2042
[runs-on, runner=8cpu-linux-x64, "run-id=${{ github.run_id }}-amd64"]
2143
steps:
@@ -55,6 +77,8 @@ jobs:
5577
provenance: false
5678

5779
build-arm64:
80+
needs: [check_model_server_changes]
81+
if: needs.check_model_server_changes.outputs.changed == 'true'
5882
runs-on:
5983
[runs-on, runner=8cpu-linux-x64, "run-id=${{ github.run_id }}-arm64"]
6084
steps:
@@ -94,7 +118,8 @@ jobs:
94118
provenance: false
95119

96120
merge-and-scan:
97-
needs: [build-amd64, build-arm64]
121+
needs: [build-amd64, build-arm64, check_model_server_changes]
122+
if: needs.check_model_server_changes.outputs.changed == 'true'
98123
runs-on: ubuntu-latest
99124
steps:
100125
- name: Login to Docker Hub

backend/tests/daily/connectors/jira/test_jira_basic.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def test_jira_connector_basic(jira_connector: JiraConnector) -> None:
3838
assert doc.source == DocumentSource.JIRA
3939
assert doc.metadata == {"priority": "Medium", "status": "Backlog"}
4040
assert doc.secondary_owners is None
41-
assert doc.title is None
41+
assert doc.title == "AS-2 test123small"
4242
assert doc.from_ingestion_api is False
4343
assert doc.additional_info is None
4444

0 commit comments

Comments
 (0)