Community Edition depends on files in `ee` folders

[marcinbienkowski]

We are trying to build Danswer following the Deployment Guide, which should result in Danswer Community Edition. However, this is not possible without some files in ee folders (which, if I understand correctly, have a non-free license). This seems to make the whole CE edition non-free.

Is this intentional?

There are several dependencies, the strangest one is probably this: the file backend/danswer/server/danswer_api/ingestion.py contains the line from ee.danswer.auth.users import api_key_dep. This seems to be a core feature - authorizing users and checking their admin privileges.

[marcinbienkowski]

Apart from api_key_dep, the remaining dependencies are quite shallow. It seems that danswer/backend/danswer/server/token_rate_limits/api.py requires the following 4 functions:

• fetch_all_user_token_rate_limits
• insert_global_token_rate_limit
• delete_token_rate_limit
• update_token_rate_limit

All of them are short functions that just read/write appropriate parameters from persistent storage. Would you consider moving them outside ee folder?

[hurrdurrsan]

Hi @marcinbienkowski, if by any chance you already put some effort into excluding ee folder code from the rest, I would really appreciate any guidance. This must be intentional as you mentioned, same as differentiating CE and EE by security feature bargain instead of other exclusive features. I do not want to come out as unthankful for the really nice piece of open source code, but it is what it is.

[github-actions]

This issue is stale because it has been open 75 days with no activity. Remove stale label or comment or this will be closed in 15 days.

[github-actions]

This issue was closed because it has been stalled for 90 days with no activity.

[Weves]

Thanks @marcinbienkowski and @hurrdurrsan for bringing this up! It is not intentional—we definitely want to keep the MIT portion of the codebase clean and modifiable. We plan to get to it this week. Will update here once it's done!

[hurrdurrsan]

Thanks @marcinbienkowski and @hurrdurrsan for bringing this up! It is not intentional—we definitely want to keep the MIT portion of the codebase clean and modifiable. We plan to get to it this week. Will update here once it's done!

Hi, any update on this?

[Weves]

@hurrdurrsan apologies on the delay here — that week was hectic and it just got lost in the shuffle. Will absolutely make sure we get to this this week.

To re-iterate this to all Community Edition users: you have my word (as one of the maintainers / founders) that you are completely good to go with using the project — the intent is 100% to have the Community Edition as a MIT licensed project.

I understand this likely will not appease folks in compliance, but just wanted to put that out there for what its worth.

[Weves]

Hey @marcinbienkowski and @hurrdurrsan — this has been addressed with #4682 and #4690!

Let me know if there's anything else we can do to help. Any and all feedback and suggestions are more than welcome!