Skip to content

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Oct 1, 2024

Description

Fix https://linear.app/danswer/issue/DAN-745/azure-openai-and-likely-other-model-providers-dont-work

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 8:45pm

@pablonyx pablonyx marked this pull request as ready for review October 1, 2024 22:39
"Update"
) : (
"Enable"
"Enableasdf"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may want to remove this

Copy link
Contributor Author

@pablonyx pablonyx Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fair

@Weves Weves merged commit b04e9e9 into main Oct 5, 2024
6 of 7 checks passed
@Weves Weves deleted the all_providers branch October 5, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants