Skip to content

Reduce the scope of the prune test #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+1 −11
Closed

Reduce the scope of the prune test #2842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions backend/tests/integration/connector_job_tests/slack/test_prune.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def test_slack_prune(
cc_pair: DATestCCPair = CCPairManager.create(
credential_id=credential.id,
connector_id=connector.id,
access_type=AccessType.SYNC,
access_type=AccessType.PUBLIC,
user_performing_action=admin_user,
)
CCPairManager.wait_for_indexing(
Expand All @@ -91,19 +91,13 @@ def test_slack_prune(
)

public_message = "Steve's favorite number is 809752"
private_message = "Sara's favorite number is 346794"
message_to_delete = "Rebecca's favorite number is 753468"

SlackManager.add_message_to_channel(
slack_client=slack_client,
channel=public_channel,
message=public_message,
)
SlackManager.add_message_to_channel(
slack_client=slack_client,
channel=private_channel,
message=private_message,
)
SlackManager.add_message_to_channel(
slack_client=slack_client,
channel=private_channel,
Expand Down Expand Up @@ -144,7 +138,6 @@ def test_slack_prune(

# Ensure admin user can see all messages
assert public_message in danswer_doc_message_strings
assert private_message in danswer_doc_message_strings
assert message_to_delete in danswer_doc_message_strings

# Search as test_user_1 with access to both channels
Expand All @@ -159,7 +152,6 @@ def test_slack_prune(

# Ensure test_user_1 can see all messages
assert public_message in danswer_doc_message_strings
assert private_message in danswer_doc_message_strings
assert message_to_delete in danswer_doc_message_strings

# ----------------------MAKE THE CHANGES--------------------------
Expand Down Expand Up @@ -190,7 +182,6 @@ def test_slack_prune(

# Ensure admin can't see deleted messages
assert public_message in danswer_doc_message_strings
assert private_message in danswer_doc_message_strings
assert message_to_delete not in danswer_doc_message_strings

# Ensure test_user_1 can't see deleted messages
Expand All @@ -206,5 +197,4 @@ def test_slack_prune(

# Ensure test_user_1 can't see deleted messages
assert public_message in danswer_doc_message_strings
assert private_message in danswer_doc_message_strings
assert message_to_delete not in danswer_doc_message_strings