Skip to content

Conversation

@yuhongsun96
Copy link
Contributor

Description

"external" users when trying to create accounts in the web UI get redirected to a page waiting on email verification if the deployment is using SAML (and possibly other auth methods).

How Has This Been Tested?

This has not been reproduced but the logic for email verification seems wrong and should prevent this.

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

@vercel
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 5:40am

@Weves Weves added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit db69e44 Dec 6, 2024
12 of 13 checks passed
@rkuo-danswer rkuo-danswer deleted the fix-verification-bug branch May 12, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants