Skip to content

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Dec 10, 2024

Description

Fixes https://linear.app/danswer/issue/DAN-1119/citations-are-not-clickable-on-slack-a-large-chunk-of-the-time
Semantic ID for slack connector could contain newlines which caused issues for Slackbot formatting

Before and After
Screenshot 2024-12-10 at 1 12 29 PM

Screenshot 2024-12-10 at 1 12 21 PM

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

@pablonyx pablonyx changed the title stripe text for slackbot strip text for slackbot Dec 10, 2024
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 9:17pm

@rkuo-danswer rkuo-danswer added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 1f2b7cb Dec 10, 2024
13 checks passed
@rkuo-danswer rkuo-danswer deleted the slackbot_semantic_id_strip branch May 12, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants