Skip to content

Conversation

skylares
Copy link
Contributor

@skylares skylares commented Dec 17, 2024

Description

A hook to simplify receiving paginated data from the db.

usertable

Backend Changes:

  • Added an API endpoint and DB functions to return paginated user data and to allow filtering by user role and status.
  • Added the necessary types for the paginated return of users and indexing attempts.
  • Added tests for the users API to ensure pagination and filtering work as intended.
  • Modified the indexing attempts API endpoint to use the updated return type.

Frontend Changes:

  • Added a hook for handling pagination
  • Updated the users table to use the hook
  • Updated the indexing attempts table to use the hook
  • Added filtering by role and status for the users table

Copy link

vercel bot commented Dec 17, 2024

@skylares is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I pointed out a lot of small things that aren't critical but I'm trying to be helpful to your learning so being extra nit picky.

Stopped at the test utilities file, ran out of time and have to move on to other work, Hagen will take a pass after this.

@hagen-danswer hagen-danswer merged commit c191e23 into onyx-dot-app:main Jan 3, 2025
3 of 7 checks passed
@skylares skylares deleted the pagination-hook branch January 4, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants