Performance monitoring #3658
Merged
Performance monitoring #3658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Weves
force-pushed
the
performance-monitoring
branch
from
e39586d to
896fd18
Compare
| logger.info(f"Multiprocessing start method: {multiprocessing.get_start_method()}") | ||
|
|
||
| SqlEngine.set_app_name(POSTGRES_CELERY_WORKER_MONITORING_APP_NAME) | ||
| SqlEngine.init_engine(pool_size=sender.concurrency, max_overflow=8) |
There was a problem hiding this comment.
how many db connections do we think the monitoring worker is going to need? it looks like this was borrowed from the light worker which is a relatively large case.
| SyncRecord.sync_type == sync_type, | ||
| ) | ||
| ) | ||
| .order_by(desc(SyncRecord.sync_start_time)) |
There was a problem hiding this comment.
looks like we have an index here, which is good
Weves
commented
Jan 13, 2025
Weves
commented
Jan 13, 2025
Weves
commented
Jan 13, 2025
backend/alembic/versions/fec3db967bf7_add_time_updated_to_usergroup_and_.py
Outdated
Show resolved
Hide resolved
Weves
commented
Jan 13, 2025
Weves
commented
Jan 13, 2025
rkuo-danswer
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds metrics for various background performance signals (e.g. latency between when a job should start vs when it does start).
How Has This Been Tested?
Tested manually with indexing, document sets, user groups, and deleting.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.