use persona info when creating tool args #4397
Merged
+54
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refines tool argument construction by leveraging persona information from the prompt builder to improve both forced and automatic tool calls.
- In backend/onyx/chat/tool_handling/tool_response_handler.py, get_tool_call_for_non_tool_calling_llm_impl now uses AnswerPromptBuilder to refine the user query.
- In backend/onyx/chat/process_message.py, prompt assignment now defaults to the first persona prompt if final_msg.prompt is missing; ensure handling of empty or invalid persona.prompts.
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+663
to
+800
| prompt_config = PromptConfig.from_model( | ||
| final_msg.prompt or persona.prompts[0] | ||
| ) |
There was a problem hiding this comment.
logic: Ensure persona.prompts is non-empty to avoid index errors if final_msg.prompt is falsy.
evan-onyx
force-pushed
the
non-explicit-tool-call-use-persona-prompt
branch
from
34a0d24 to
4d7745e
Compare
evan-onyx
force-pushed
the
non-explicit-tool-call-use-persona-prompt
branch
from
6793334 to
59451f2
Compare
Weves
reviewed
Apr 8, 2025
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Apr 26, 2025
* use persona info when creating tool args * fixed unit test * include system message * fix unit test * nit
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* use persona info when creating tool args * fixed unit test * include system message * fix unit test * nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1634/address-weird-tool-calling-behavior-with-claude-37
How Has This Been Tested?
tested in UI + tests now cover this case (ensure that system message is in task prompt)
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.