Drive smart chip indexing #4459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The PR enhances the Google Drive connector's extraction and indexing of smart chips by integrating multiple retrieval methods and refining section alignment.
- /backend/onyx/connectors/google_drive/appsscript.json: New configuration enabling the advanced Docs service in a V8 environment.
- /backend/onyx/chat/process_message.py: Streamlined deduplication logic using a clearer conditional expression.
- /backend/onyx/connectors/google_drive/section_extraction.py: Improved tab handling and structured processing of headings and tables.
- /backend/onyx/connectors/google_drive/doc_conversion.py: Introduced best-effort alignment between basic and advanced extraction with warnings for misalignments.
- /backend/onyx/connectors/google_drive/smart_chip_retrieval.gs: New Apps Script for smart chip extraction with potential Map usage concerns.
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
evan-onyx
force-pushed
the
drive-pill-indexing2
branch
from
e8946fb to
2356674
Compare
Weves
approved these changes
Apr 7, 2025
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Apr 26, 2025
* WIP * WIP almost done, but realized we can just do basic retrieval * rebased and added scripts * improved approach to extracting smart chips * remove files from previous branch * fix connector tests * fix test
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* WIP * WIP almost done, but realized we can just do basic retrieval * rebased and added scripts * improved approach to extracting smart chips * remove files from previous branch * fix connector tests * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1684/handle-date-pills-and-other-similar-things-in-google-docs
Index smart chips in Google Docs. We know of three ways to get content from Google Docs. Here are some pros/cons
a) Docs advanced API v1
Pros: Allows structured retrieval, i.e. can extract headings
Cons: missing smart chips (dates, timers, calendar events, etc). DOES extract people and docs links.
b) Drive file retrieval
Pros: gets ALL smart chips, all text content.
Cons: no structure
c) Apps Scripting
Pros: structured retrieval, DOES get dates
Cons: misses all other smart chips, requires users to enable a bunch of extra scopes
This PR addresses some prior issues with the Advanced retrieval (missing the first section, not getting tables). It also detects when a doc contains smart chips, and if so uses (b) to get the full file content, then best-effort combines with section information from (a) to get full-content docs with reasonable section information.
We switched away from (c) upon realizing that (b) had more information than previously thought, but the code from that approach is available in the drive-pill-indexing branch.
How Has This Been Tested?
Tested in UI, should add an integration test at some point
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.