Minor doc set fix #4480
Merged
Minor doc set fix #4480
+20
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces a new "document_sets" field to both PersonaSnapshot and FullPersonaSnapshot, clarifies association handling in upsert_persona, and refines the knowledge_source initialization in AssistantEditor.
- Updated
/backend/onyx/server/features/persona/models.pyto build document_sets via DocumentSet.from_model with a default empty list. - Added a clarifying comment in
/backend/onyx/db/persona.pyabout preserving existing document_set associations. - Modified
/web/src/app/admin/assistants/AssistantEditor.tsxto set knowledge_source based on existing persona data.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Weves
approved these changes
Apr 8, 2025
tim-dim
pushed a commit
to GrantHive/grantgpt-dev
that referenced
this pull request
Apr 8, 2025
* update * update * update * k
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Apr 26, 2025
* update * update * update * k
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* update * update * update * k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1780/document-sets-issue
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.