fix: Remove advanced options toggle if enterprise features are not enabled #4489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR conditionally removes the Advanced Options toggle on the custom LLM provider form for non-enterprise users.
- Conditionally wrap the Advanced Options block in
/web/src/app/admin/configuration/llm/CustomLLMProviderUpdateForm.tsxusing theusePaidEnterpriseFeaturesEnabledhook. - Prevents rendering an empty dropdown by omitting the toggle for non-enterprise accounts.
- Applies minor formatting tweaks to className strings.
💡 (5/5) You can turn off certain types of comments like style here!
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
rkuo-danswer
approved these changes
Apr 9, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 9, 2025
…abled (#4489) * Only show advanced options for custom llm providers *if* the paid features are enabled * Change variable name
tim-dim
pushed a commit
to GrantHive/grantgpt-dev
that referenced
this pull request
Apr 10, 2025
…abled (onyx-dot-app#4489) * Only show advanced options for custom llm providers *if* the paid features are enabled * Change variable name
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Apr 26, 2025
…abled (onyx-dot-app#4489) * Only show advanced options for custom llm providers *if* the paid features are enabled * Change variable name
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
…abled (onyx-dot-app#4489) * Only show advanced options for custom llm providers *if* the paid features are enabled * Change variable name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding a new custom LLM provider, the model contains an "Advanced Options" toggle at the bottom. However, for non-enterprise users, the dropdown will be empty. However, the toggle still exists; it just expands to nothing.
This PR removes that toggle if enterprise features are not enabled.
Addresses: https://linear.app/danswer/issue/DAN-1789/remove-advanced-options-toggle-if-paid-enterprise-features-are-not
How Has This Been Tested?
UI fix; only visually tested.
Screenshots
Before:
After:
